shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions 6 Packages Projects Releases Wiki Activity

[OpenMP][OMPT] Remove Threads dependency from omptest (#185930)

Browse Source 
Removed link against `Threads`.
Reason: it is potentially problematic and optional.

The issue would manifest, if `omptest` is used via `find_package`.
But `Threads` might not be found and cause a link error.
This commit is contained in:
Michael Halkenhäuser 2026-03-12 13:08:49 +01:00 committed by GitHub
parent 754abc19f0
commit 5f97e191b3
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
openmp/tools/omptest/CMakeLists.txt
View File

@ -87,10 +87,6 @@ if ((NOT LIBOMPTEST_BUILD_STANDALONE) OR LIBOMPTEST_BUILD_UNITTESTS)
# available to dependant targets, e.g. for unit tests.
target_link_libraries(omptest PUBLIC default_gtest)
# Link against Threads (recommended for GTest).
find_package(Threads REQUIRED)
target_link_libraries(omptest PUBLIC Threads::Threads)
# Ensure that embedded GTest symbols are exported from libomptest.so even in
# builds that default to hidden.
set_target_properties(omptest PROPERTIES