shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions 6 Packages Projects Releases Wiki Activity

Revert "[clang-tidy] [Modules] Skip checking decls in clang-tidy" (#187461)

Browse Source 
Reverts llvm/llvm-project#145630

As requested in https://github.com/llvm/llvm-project/pull/145630
This commit is contained in:
Chuanqi Xu 2026-03-19 17:51:54 +08:00 committed by GitHub
parent 2bb6b59028
commit 621d40e182
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
5 changed files with 0 additions and 39 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
clang-tools-extra/clang-tidy/ClangTidy.cpp
View File

@ -434,9 +434,6 @@ ClangTidyASTConsumerFactory::createASTConsumer(CompilerInstance &Compiler,
ast_matchers::MatchFinder::MatchFinderOptions FinderOptions;
// We should always skip the declarations in modules.
FinderOptions.SkipDeclsInModules = true;
std::unique_ptr<ClangTidyProfiling> Profiling;
if (Context.getEnableProfiling()) {
Profiling =

29
clang-tools-extra/test/clang-tidy/infrastructure/cxx20-modules.cppm
View File

@ -1,29 +0,0 @@
// RUN: rm -fr %t
// RUN: mkdir %t
// RUN: split-file %s %t
// RUN: mkdir %t/tmp
//
// RUN: %check_clang_tidy -std=c++20 -check-suffix=DEFAULT %t/a.cpp \
// RUN: cppcoreguidelines-narrowing-conversions %t/a.cpp -- \
// RUN: -config='{}'
// RUN: clang -std=c++20 -x c++-module %t/a.cpp --precompile -o %t/a.pcm
// RUN: %check_clang_tidy -std=c++20 -check-suffix=DEFAULT %t/use.cpp \
// RUN: cppcoreguidelines-narrowing-conversions %t/a.cpp -- \
// RUN: -config='{}' -- -fmodule-file=a=%t/a.pcm
//--- a.cpp
export module a;
export void most_narrowing_is_not_ok() {
int i;
long long ui;
i = ui;
// CHECK-MESSAGES-DEFAULT: :[[@LINE-1]]:7: warning: narrowing conversion from 'long long' to signed type 'int' is implementation-defined [cppcoreguidelines-narrowing-conversions]
}
//--- use.cpp
import a;
void use() {
most_narrowing_is_not_ok();
}

1
clang-tools-extra/test/lit.cfg.py
View File

@ -27,7 +27,6 @@ config.test_format = lit.formats.ShTest(not use_lit_shell)
config.suffixes = [
".c",
".cpp",
".cppm",
".hpp",
".m",
".mm",

2
clang/include/clang/ASTMatchers/ASTMatchFinder.h
View File

@ -144,8 +144,6 @@ public:
/// Avoids matching declarations in system headers.
bool IgnoreSystemHeaders{false};
bool SkipDeclsInModules{false};
};
MatchFinder(MatchFinderOptions Options = MatchFinderOptions());

4
clang/lib/ASTMatchers/ASTMatchFinder.cpp
View File

@ -20,7 +20,6 @@
#include "clang/AST/ASTContext.h"
#include "clang/AST/DeclCXX.h"
#include "clang/AST/RecursiveASTVisitor.h"
#include "clang/Basic/Module.h"
#include "llvm/ADT/DenseMap.h"
#include "llvm/ADT/SmallPtrSet.h"
#include "llvm/ADT/StringMap.h"
@ -1512,9 +1511,6 @@ bool MatchASTVisitor::TraverseDecl(Decl *DeclNode) {
if (shouldSkipNode(DeclNode))
return true;
if (Options.SkipDeclsInModules && DeclNode->isInAnotherModuleUnit())
return true;
bool ScopedTraversal =
TraversingASTNodeNotSpelledInSource || DeclNode->isImplicit();
bool ScopedChildren = TraversingASTChildrenNotSpelledInSource;