From 630a4185d4ccecfbf9068dddffe8ae32daa4da5b Mon Sep 17 00:00:00 2001 From: Aaron Ballman Date: Mon, 23 Feb 2026 09:20:35 -0500 Subject: [PATCH] Re-enable MSVC C4141 diagnostic; NFC (#182586) From MSDN: https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4141?view=msvc-170 > 'modifier': used more than once This diagnostic was disabled in e11ce62707c8e0f51fce06097f71a97d02283d7a due to triggering repeatedly for combinations of __forceinline and inline. However, local testing shows that this diagnostic is no longer emitted and so I believe this can be re-enabled. --- llvm/cmake/modules/HandleLLVMOptions.cmake | 1 - 1 file changed, 1 deletion(-) diff --git a/llvm/cmake/modules/HandleLLVMOptions.cmake b/llvm/cmake/modules/HandleLLVMOptions.cmake index dc8b6b168e48..ce6eea450f99 100644 --- a/llvm/cmake/modules/HandleLLVMOptions.cmake +++ b/llvm/cmake/modules/HandleLLVMOptions.cmake @@ -745,7 +745,6 @@ if (MSVC) if (NOT CLANG_CL) set(msvc_warning_flags # Disabled warnings. - -wd4141 # Suppress ''modifier' : used more than once' (because of __forceinline combined with inline) -wd4146 # Suppress 'unary minus operator applied to unsigned type, result still unsigned' -wd4244 # Suppress ''argument' : conversion from 'type1' to 'type2', possible loss of data' -wd4267 # Suppress ''var' : conversion from 'size_t' to 'type', possible loss of data'