[Reproducers] Integrate FileProvider with clang

This patch hooks up clang and lldb's reproducers functionality. It
ensures that when capturing a reproducer, headers and modules imported
through the expression parser are collected.

Differential revision: https://reviews.llvm.org/D58076

llvm-svn: 353906
This commit is contained in:
Jonas Devlieghere 2019-02-13 01:30:41 +00:00
parent a9f91c810c
commit 63e2e59b89
7 changed files with 89 additions and 3 deletions

View File

@ -0,0 +1,2 @@
expr -- @import Cocoa
reproducer generate

View File

@ -0,0 +1,8 @@
# REQUIRES: system-darwin
#
# This tests that modules files from clang end up in the reproducer.
#
# RUN: %lldb -x -b -s %S/Inputs/ModuleCapture.in --capture %t.repro
# cat %t.repro/files.yaml | FileCheck %s
#
# CHECK: Cocoa.h

View File

@ -0,0 +1,2 @@
expr -- @import Cocoa
reproducer generate

View File

@ -0,0 +1,8 @@
# REQUIRES: system-darwin
#
# This tests that modules files from clang end up in the reproducer.
#
# RUN: %lldb -x -b -s %S/Inputs/ModuleCapture.in --capture %t.repro
# cat %t.repro/files.yaml | FileCheck %s
#
# CHECK: Cocoa.h

View File

@ -54,15 +54,15 @@
#include "llvm/Support/MemoryBuffer.h"
#include "llvm/Support/Signals.h"
#include "ClangDiagnostic.h"
#include "ClangExpressionParser.h"
#include "ClangASTSource.h"
#include "ClangDiagnostic.h"
#include "ClangExpressionDeclMap.h"
#include "ClangExpressionHelper.h"
#include "ClangExpressionParser.h"
#include "ClangModulesDeclVendor.h"
#include "ClangPersistentVariables.h"
#include "IRForTarget.h"
#include "ModuleDependencyCollector.h"
#include "lldb/Core/Debugger.h"
#include "lldb/Core/Disassembler.h"
@ -84,6 +84,7 @@
#include "lldb/Utility/DataBufferHeap.h"
#include "lldb/Utility/LLDBAssert.h"
#include "lldb/Utility/Log.h"
#include "lldb/Utility/Reproducer.h"
#include "lldb/Utility/Stream.h"
#include "lldb/Utility/StreamString.h"
#include "lldb/Utility/StringList.h"
@ -250,6 +251,19 @@ ClangExpressionParser::ClangExpressionParser(ExecutionContextScope *exe_scope,
// 1. Create a new compiler instance.
m_compiler.reset(new CompilerInstance());
// When capturing a reproducer, hook up the file collector with clang to
// collector modules and headers.
if (repro::Generator *g = repro::Reproducer::Instance().GetGenerator()) {
repro::FileProvider &fp = g->GetOrCreate<repro::FileProvider>();
m_compiler->setModuleDepCollector(
std::make_shared<ModuleDependencyCollectorAdaptor>(
fp.GetFileCollector()));
DependencyOutputOptions &opts = m_compiler->getDependencyOutputOpts();
opts.IncludeSystemHeaders = true;
opts.IncludeModuleFiles = true;
}
lldb::LanguageType frame_lang =
expr.Language(); // defaults to lldb::eLanguageTypeUnknown
bool overridden_target_opts = false;

View File

@ -22,6 +22,7 @@
#include "ClangHost.h"
#include "ClangModulesDeclVendor.h"
#include "ModuleDependencyCollector.h"
#include "lldb/Core/ModuleList.h"
#include "lldb/Host/Host.h"
@ -31,6 +32,7 @@
#include "lldb/Utility/FileSpec.h"
#include "lldb/Utility/LLDBAssert.h"
#include "lldb/Utility/Log.h"
#include "lldb/Utility/Reproducer.h"
#include "lldb/Utility/StreamString.h"
using namespace lldb_private;
@ -631,6 +633,18 @@ ClangModulesDeclVendor::Create(Target &target) {
std::unique_ptr<clang::CompilerInstance> instance(
new clang::CompilerInstance);
// When capturing a reproducer, hook up the file collector with clang to
// collector modules and headers.
if (repro::Generator *g = repro::Reproducer::Instance().GetGenerator()) {
repro::FileProvider &fp = g->GetOrCreate<repro::FileProvider>();
instance->setModuleDepCollector(
std::make_shared<ModuleDependencyCollectorAdaptor>(
fp.GetFileCollector()));
clang::DependencyOutputOptions &opts = instance->getDependencyOutputOpts();
opts.IncludeSystemHeaders = true;
opts.IncludeModuleFiles = true;
}
instance->setDiagnostics(diagnostics_engine.get());
instance->setInvocation(invocation);

View File

@ -0,0 +1,38 @@
//===-- ModuleDependencyCollector.h -----------------------------*- C++ -*-===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#ifndef liblldb_ModuleDependencyCollector_h_
#define liblldb_ModuleDependencyCollector_h_
#include "lldb/Utility/FileCollector.h"
#include "clang/Frontend/Utils.h"
#include "llvm/ADT/StringRef.h"
namespace lldb_private {
class ModuleDependencyCollectorAdaptor
: public clang::ModuleDependencyCollector {
public:
ModuleDependencyCollectorAdaptor(FileCollector &file_collector)
: clang::ModuleDependencyCollector(""), m_file_collector(file_collector) {
}
void addFile(llvm::StringRef Filename,
llvm::StringRef FileDst = {}) override {
m_file_collector.AddFile(Filename);
}
bool insertSeen(llvm::StringRef Filename) override { return false; }
void addFileMapping(llvm::StringRef VPath, llvm::StringRef RPath) override {}
void writeFileMap() override {}
private:
FileCollector &m_file_collector;
};
} // namespace lldb_private
#endif