shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions 6 Packages Projects Releases Wiki Activity

[flang][cuda] Check for use of host array in device context (#119756)

Browse Source 
Now that variables have implicit attribute, we can check for illegal use
of module host variable in device context.
This commit is contained in:
Valentin Clement (バレンタイン クレメン) 2024-12-16 13:34:22 -08:00 committed by GitHub
parent 484a2819de
commit 67ae944bfa
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 13 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
flang/lib/Semantics/check-cuda.cpp
View File

@ -340,7 +340,7 @@ private:
void ErrorIfHostSymbol(const A &expr, parser::CharBlock source) {
if (const Symbol * hostArray{FindHostArray{}(expr)}) {
context_.Say(source,
"Host array '%s' cannot be present in CUF kernel"_err_en_US,
"Host array '%s' cannot be present in device context"_err_en_US,
hostArray->name());
}
}
@ -387,13 +387,10 @@ private:
Check(x.value());
},
[&](const common::Indirection<parser::AssignmentStmt> &x) {
if (IsCUFKernelDo) {
const evaluate::Assignment *assign{
semantics::GetAssignment(x.value())};
if (assign) {
ErrorIfHostSymbol(assign->lhs, source);
ErrorIfHostSymbol(assign->rhs, source);
}
if (const evaluate::Assignment *
assign{semantics::GetAssignment(x.value())}) {
ErrorIfHostSymbol(assign->lhs, source);
ErrorIfHostSymbol(assign->rhs, source);
}
if (auto msg{ActionStmtChecker<IsCUFKernelDo>::WhyNotOk(x)}) {
context_.Say(source, std::move(*msg));

9
flang/test/Semantics/cuf09.cuf
View File

@ -1,5 +1,6 @@
! RUN: %python %S/test_errors.py %s %flang_fc1
module m
integer :: m(100)
contains
attributes(device) subroutine devsub
!ERROR: Statement may not appear in device code
@ -15,6 +16,12 @@ module m
!WARNING: I/O statement might not be supported on device
write(12,'(10F4.1)'), x
end
attributes(global) subroutine hostglobal(a)
integer :: a(*)
i = threadIdx%x
!ERROR: Host array 'm' cannot be present in device context
if (i .le. N) a(i) = m(i)
end subroutine
end
program main
@ -96,7 +103,7 @@ program main
!$cuf kernel do (2) <<<*, *>>>
do j = 1, 10
do i = 1, 10
!ERROR: Host array 'b' cannot be present in CUF kernel
!ERROR: Host array 'b' cannot be present in device context
a_d(i,j) = b(i,j)
enddo
enddo