shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions 6 Packages Projects Releases Wiki Activity

[clang-tidy] Fix false positive from readability-redundant-typename on partially specialized variables (#175473)

Browse Source 
Fixes #174827.
This commit is contained in:
Victor Chernyakin 2026-01-14 00:09:22 -07:00 committed by GitHub
parent 0ae23ca9e6
commit 6ddab42952
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 25 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
clang-tools-extra/clang-tidy/readability/RedundantTypenameCheck.cpp
View File

@ -25,22 +25,25 @@ void RedundantTypenameCheck::registerMatchers(MatchFinder *Finder) {
if (!getLangOpts().CPlusPlus20)
return;
const auto InImplicitTypenameContext = anyOf(
hasParent(decl(anyOf(
typedefNameDecl(), templateTypeParmDecl(), nonTypeTemplateParmDecl(),
friendDecl(), fieldDecl(),
varDecl(hasDeclContext(anyOf(namespaceDecl(), translationUnitDecl())),
unless(parmVarDecl())),
parmVarDecl(hasParent(expr(requiresExpr()))),
parmVarDecl(hasParent(typeLoc(hasParent(decl(
anyOf(cxxMethodDecl(), hasParent(friendDecl()),
const auto InImplicitTypenameContext =
anyOf(hasParent(decl(anyOf(
typedefNameDecl(), templateTypeParmDecl(),
nonTypeTemplateParmDecl(), friendDecl(), fieldDecl(),
parmVarDecl(hasParent(expr(requiresExpr()))),
parmVarDecl(hasParent(typeLoc(hasParent(decl(anyOf(
cxxMethodDecl(), hasParent(friendDecl()),
functionDecl(has(nestedNameSpecifier())),
cxxDeductionGuideDecl(hasDeclContext(recordDecl())))))))),
// Match return types.
functionDecl(unless(cxxConversionDecl()))))),
hasParent(expr(anyOf(cxxNamedCastExpr(), cxxNewExpr()))));
// Match return types.
functionDecl(unless(cxxConversionDecl()))))),
hasParent(expr(anyOf(cxxNamedCastExpr(), cxxNewExpr()))));
Finder->addMatcher(
typeLoc(InImplicitTypenameContext).bind("dependentTypeLoc"), this);
Finder->addMatcher(
varDecl(hasDeclContext(anyOf(namespaceDecl(), translationUnitDecl())),
unless(parmVarDecl()),
hasTypeLoc(typeLoc().bind("dependentTypeLoc"))),
this);
}
void RedundantTypenameCheck::check(const MatchFinder::MatchResult &Result) {

10
clang-tools-extra/test/clang-tidy/checkers/readability/redundant-typename.cpp
View File

@ -157,6 +157,16 @@ typename T::R v = typename T::R();
// CHECK-MESSAGES-20: :[[@LINE-1]]:1: warning: redundant 'typename' [readability-redundant-typename]
// CHECK-FIXES-20: T::R v = typename T::R();
template <typename T, typename>
typename T::R PartiallySpecializedVariable = true;
// CHECK-MESSAGES-20: :[[@LINE-1]]:1: warning: redundant 'typename' [readability-redundant-typename]
// CHECK-FIXES-20: T::R PartiallySpecializedVariable = true;
template <typename T>
typename T::R PartiallySpecializedVariable<T, typename T::R> = false;
// CHECK-MESSAGES-20: :[[@LINE-1]]:1: warning: redundant 'typename' [readability-redundant-typename]
// CHECK-FIXES-20: T::R PartiallySpecializedVariable<T, typename T::R> = false;
#endif // __cplusplus >= 201402L
template <typename T>