shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions 6 Packages Projects Releases Wiki Activity

[orc-rt] Add Session::tryCreateService convenience function. (#187640)

Browse Source 
Session::tryCreateService will try to create an instance of ServiceT by
forwarding the given arguments to the ServiceT::Create method, which
must return an Expected<std::unique_ptr<ServiceT>>.

This enables one-line construction and registration of Services with
fallible constructors (which are expected to be common).
This commit is contained in:
Lang Hames 2026-03-22 16:58:19 +11:00 committed by GitHub
parent 3258d361cb
commit 6f6adfbca4
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 41 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
orc-rt/include/orc-rt/Session.h
View File

@ -191,6 +191,20 @@ public:
return addService(std::make_unique<ServiceT>(std::forward<ArgTs>(Args)...));
}
/// Try to create an instance of ServiceT by forwarding the given arguments
/// to ServiceT::Create method, which must return an
/// Expected<std::unique_ptr<ServiceT>>.
///
/// On success, adds the service and returns a reference to it.
/// On failure returns the Error produced by ServiceT::Create.
template <typename ServiceT, typename... ArgTs>
Expected<ServiceT &> tryCreateService(ArgTs &&...Args) {
auto Srv = ServiceT::Create(std::forward<ArgTs>(Args)...);
if (!Srv)
return Srv.takeError();
return addService(std::move(*Srv));
}
/// Initiate connection with controller, using the given BootstrapInfo.
///
/// Upon first call, assuming that the Session has not already been detached

27
orc-rt/unittests/SessionTest.cpp
View File

@ -63,6 +63,13 @@ class ConfigurableService : public Service {
public:
ConfigurableService(int ConstructorOption) {}
/// Fallible named constructor for testing tryCreateService.
static Expected<std::unique_ptr<ConfigurableService>> Create(bool Fail) {
if (Fail)
return make_error<StringError>("failed to create service");
return std::make_unique<ConfigurableService>(42);
}
void onDetach(OnCompleteFn OnComplete, bool ShutdownRequested) override {
OnComplete();
}
@ -399,6 +406,26 @@ TEST(SessionTest, CreateServiceAndUseRef) {
CS.doMoreConfig(1);
}
TEST(SessionTest, TryCreateServiceSuccess) {
Session S(mockExecutorProcessInfo(), std::make_unique<NoDispatcher>(),
noErrors);
auto CS = S.tryCreateService<ConfigurableService>(false);
if (auto Err = CS.takeError()) {
ADD_FAILURE() << "expected service creation to succeed";
consumeError(std::move(Err));
}
}
TEST(SessionTest, TryCreateServiceFailure) {
Session S(mockExecutorProcessInfo(), std::make_unique<NoDispatcher>(),
noErrors);
auto CS = S.tryCreateService<ConfigurableService>(true);
if (auto Err = CS.takeError())
consumeError(std::move(Err));
else
ADD_FAILURE() << "expected service creation to fail";
}
TEST(ControllerAccessTest, Basics) {
// Test that we can set the ControllerAccess implementation and still shut
// down as expected.