From 70605ff452a8a45aa6924baff60bed14eb8fb00a Mon Sep 17 00:00:00 2001 From: Julian Lettner Date: Thu, 30 Apr 2020 18:15:50 -0700 Subject: [PATCH] [lit] Don't crash for --time-tests in aborted test run Properly print the test times histogram even for aborted (user interrupt, [Ctrl+C]) test runs. --- llvm/utils/lit/lit/main.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/llvm/utils/lit/lit/main.py b/llvm/utils/lit/lit/main.py index 3f3b34aff15e..bbaeb0d6b34e 100755 --- a/llvm/utils/lit/lit/main.py +++ b/llvm/utils/lit/lit/main.py @@ -94,7 +94,7 @@ def main(builtin_params={}): t for t in selected_tests if t.result.code != lit.Test.SKIPPED] if opts.time_tests: - print_histogram(executed_tests) + print_histogram(discovered_tests) print_results(discovered_tests, elapsed, opts) @@ -257,8 +257,10 @@ def execute_in_tmp_dir(run, lit_config): def print_histogram(tests): - test_times = [(t.getFullName(), t.result.elapsed) for t in tests] - lit.util.printHistogram(test_times, title='Tests') + test_times = [(t.getFullName(), t.result.elapsed) + for t in tests if t.result.elapsed] + if test_times: + lit.util.printHistogram(test_times, title='Tests') def add_result_category(result_code, label):