From 71a848632e2fbef3f2dc97c2dae845ddca0ec47e Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 24 Jul 2024 10:45:00 +0100 Subject: [PATCH] [libcxx][test] Update picolib xfails (#99631) clang_modules_include.gen.py works now, and I added some background to classic_table.pass.cpp. Opened https://github.com/picolibc/picolibc/issues/778 to see if that one is possible to fix. --- libcxx/test/libcxx/clang_modules_include.gen.py | 3 --- .../facet.ctype.char.statics/classic_table.pass.cpp | 4 ++++ 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/libcxx/test/libcxx/clang_modules_include.gen.py b/libcxx/test/libcxx/clang_modules_include.gen.py index 7ba4bf032624..f084c38a8fbd 100644 --- a/libcxx/test/libcxx/clang_modules_include.gen.py +++ b/libcxx/test/libcxx/clang_modules_include.gen.py @@ -37,9 +37,6 @@ for header in public_headers: // TODO: Investigate this failure // UNSUPPORTED: LIBCXX-FREEBSD-FIXME -// TODO: Investigate this failure -// UNSUPPORTED: LIBCXX-PICOLIBC-FIXME - {lit_header_restrictions.get(header, '')} #include <{header}> diff --git a/libcxx/test/std/localization/locale.categories/category.ctype/facet.ctype.special/facet.ctype.char.statics/classic_table.pass.cpp b/libcxx/test/std/localization/locale.categories/category.ctype/facet.ctype.special/facet.ctype.char.statics/classic_table.pass.cpp index 50c60180ce0d..1bd9fc88c72d 100644 --- a/libcxx/test/std/localization/locale.categories/category.ctype/facet.ctype.special/facet.ctype.char.statics/classic_table.pass.cpp +++ b/libcxx/test/std/localization/locale.categories/category.ctype/facet.ctype.special/facet.ctype.char.statics/classic_table.pass.cpp @@ -6,6 +6,10 @@ // //===----------------------------------------------------------------------===// +// Picolibc/newlib checks for the blank flag in isprint, which needs to be false +// for tab. So they removed the _B flag from the ctype data, which causes this +// test to fail. +// See https://github.com/picolibc/picolibc/issues/778. // XFAIL: LIBCXX-PICOLIBC-FIXME //