shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions 6 Packages Projects Releases Wiki Activity

[CI] Tweak wording for builds with passing tests and build errors (#171436)

Browse Source 
"All tests passed" is too easily interpreted as every possible test was
run and was fine. A lot of the time it means all the tests that didn't
fail to build ran and were fine.

Maybe the wording is still too subtle but at least it hints to the idea
that the tests run might be fewer than if the build had no compilation
errors.
This commit is contained in:
David Spickett 2025-12-09 16:33:29 +00:00 committed by GitHub
parent c61a481a23
commit 76cffd310a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
.ci/generate_test_report_lib.py
View File

@ -267,7 +267,7 @@ def generate_report(
report.extend(
[
"",
"All tests passed but another part of the build **failed**. "
"All executed tests passed, but another part of the build **failed**. "
"Information about the build failure could not be automatically "
"obtained.",
"",
@ -278,7 +278,7 @@ def generate_report(
report.extend(
[
"",
"All tests passed but another part of the build **failed**. Click on "
"All executed tests passed, but another part of the build **failed**. Click on "
"a failure below to see the details.",
"",
]

8
.ci/generate_test_report_lib_test.py
View File

@ -343,7 +343,7 @@ class TestReports(unittest.TestCase):
* 1 test passed
All tests passed but another part of the build **failed**. Information about the build failure could not be automatically obtained.
All executed tests passed, but another part of the build **failed**. Information about the build failure could not be automatically obtained.
Download the build's log file to see the details.
@ -390,7 +390,7 @@ class TestReports(unittest.TestCase):
* 1 test passed
All tests passed but another part of the build **failed**. Click on a failure below to see the details.
All executed tests passed, but another part of the build **failed**. Click on a failure below to see the details.
<details>
<summary>test/4.stamp</summary>
@ -476,7 +476,7 @@ class TestReports(unittest.TestCase):
* 1 test passed
All tests passed but another part of the build **failed**. Click on a failure below to see the details.
All executed tests passed, but another part of the build **failed**. Click on a failure below to see the details.
<details>
<summary>touch test/2.stamp</summary>
@ -978,7 +978,7 @@ class TestReports(unittest.TestCase):
* 1 test passed
All tests passed but another part of the build **failed**. Click on a failure below to see the details.
All executed tests passed, but another part of the build **failed**. Click on a failure below to see the details.
<details>
<summary>test/4.stamp</summary>