shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[clang-tidy] Fix regression in RenamerClangTidy

Browse Source 
See bug https://bugs.llvm.org/show_bug.cgi\?id\=46976
This commit is contained in:
Nathan James 2020-08-04 09:27:01 +01:00
parent 8f576a7566
commit 7c4782ce91
No known key found for this signature in database
GPG Key ID: CC007AFCDA90AA5F
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp
View File

@ -157,6 +157,9 @@ void RenamerClangTidyCheck::addUsage(
RenamerClangTidyCheck::NamingCheckFailure &Failure =
NamingCheckFailures[Decl];
if (!Failure.RawUsageLocs.insert(FixLocation.getRawEncoding()).second)
return;
if (!Failure.ShouldFix())
return;
@ -165,8 +168,6 @@ void RenamerClangTidyCheck::addUsage(
if (!utils::rangeCanBeFixed(Range, SourceMgr))
Failure.FixStatus = RenamerClangTidyCheck::ShouldFixStatus::InsideMacro;
Failure.RawUsageLocs.insert(FixLocation.getRawEncoding());
}
void RenamerClangTidyCheck::addUsage(const NamedDecl *Decl, SourceRange Range,

5
clang-tools-extra/test/clang-tidy/checkers/readability-identifier-naming.cpp
View File

@ -578,3 +578,8 @@ void Foo() {
#undef M1
#undef DUP
} // namespace scratchspace
template<typename type_t>
auto GetRes(type_t& Param) -> decltype(Param.res());
// CHECK-MESSAGES: :[[@LINE-1]]:21: warning: invalid case style for parameter 'Param'
// CHECK-FIXES: auto GetRes(type_t& a_param) -> decltype(a_param.res());