shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[Github] Fix TODO after removal of continue on error (#141896)

Browse Source 
Previously we were using continue-on-error within the workflows to
prevent sending out notifications for workflow failures. We worked
around this in the metrics container to see what was actually
failing/passing by looking at the individual steps. Now that we have
gotten rid of the continue-on-error flag, we just have to look at the
job status.
This commit is contained in:
Aiden Grossman 2025-05-29 15:58:51 +00:00 committed by GitHub
parent 62e28d4c31
commit 7d44430f66
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
.ci/metrics/metrics.py
View File

@ -349,19 +349,7 @@ def github_get_metrics(
running_count[metric_name] += 1
continue
job_result = int(job.conclusion == "success")
if job_result:
# We still might want to mark the job as a failure if one of the steps
# failed. This is required due to use setting continue-on-error in
# the premerge pipeline to prevent sending emails while we are
# testing the infrastructure.
# TODO(boomanaiden154): Remove this once the premerge pipeline is no
# longer in a testing state and we can directly assert the workflow
# result.
for step in job.steps:
if step.conclusion != "success" and step.conclusion != "skipped":
job_result = 0
break
job_result = int(job.conclusion == "success" or job.conclusion == "skipped")
created_at = job.created_at
started_at = job.started_at