shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[ompd] Fix strict aliasing violation in TargetValue::getValue() (#97739)

Browse Source 
For the case where baseTypeSize does not match the size of T, read the
value into a separate char buffer first. This avoids accessing buf using
two different types.

Fixes https://github.com/llvm/llvm-project/issues/94616.
This commit is contained in:
Nikita Popov 2024-07-05 09:26:54 +02:00 committed by GitHub
parent eb7ebd51ec
commit 8101cbff77
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 21 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
openmp/libompd/src/TargetValue.h
View File

@ -231,22 +231,27 @@ public:
template <typename T> ompd_rc_t TBaseValue::getValue(T &buf) {
assert(sizeof(T) >= baseTypeSize);
ompd_rc_t ret = getValue(&buf, 1);
if (sizeof(T) > baseTypeSize) {
switch (baseTypeSize) {
case 1:
buf = (T) * ((int8_t *)&buf);
break;
case 2:
buf = (T) * ((int16_t *)&buf);
break;
case 4:
buf = (T) * ((int32_t *)&buf);
break;
case 8:
buf = (T) * ((int64_t *)&buf);
break;
}
if (sizeof(T) == baseTypeSize)
return getValue(&buf, 1);
char tmp[sizeof(T)];
ompd_rc_t ret = getValue(tmp, 1);
switch (baseTypeSize) {
case 1:
buf = (T) * ((int8_t *)tmp);
break;
case 2:
buf = (T) * ((int16_t *)tmp);
break;
case 4:
buf = (T) * ((int32_t *)tmp);
break;
case 8:
buf = (T) * ((int64_t *)tmp);
break;
default:
assert(0 && "Invalid baseTypeSize");
break;
}
return ret;
}