shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[clangd] Disable cppcoreguidelines-macro-to-enum clang-tidy checker (#129478)

Browse Source 
Clangd does not support its checker because the checker relies on having
seen preprocessor conditionals that occur in the preamble, and clangd
does not currently replay those.

This checker was already disabled under its main name,
modernize-macro-to-enum (https://github.com/clangd/clangd/issues/1464).
This commit disables it under the alternative name
cppcoreguidelines-macro-to-enum as well.

Fixes https://github.com/llvm/llvm-project/issues/127965
This commit is contained in:
Nathan Ridge 2025-03-04 03:46:54 -05:00 committed by GitHub
parent 80bdfcd411
commit 8266cd9f84
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
clang-tools-extra/clangd/TidyProvider.cpp
View File

@ -210,6 +210,7 @@ TidyProvider disableUnusableChecks(llvm::ArrayRef<std::string> ExtraBadChecks) {
// Check relies on seeing ifndef/define/endif directives, // Check relies on seeing ifndef/define/endif directives,
// clangd doesn't replay those when using a preamble. // clangd doesn't replay those when using a preamble.
"-llvm-header-guard", "-modernize-macro-to-enum", "-llvm-header-guard", "-modernize-macro-to-enum",
"-cppcoreguidelines-macro-to-enum",
// ----- Crashing Checks ----- // ----- Crashing Checks -----

15
clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp
View File

@ -823,6 +823,21 @@ TEST(DiagnosticTest, ClangTidyNoLiteralDataInMacroToken) {
EXPECT_THAT(TU.build().getDiagnostics(), UnorderedElementsAre()); // no-crash EXPECT_THAT(TU.build().getDiagnostics(), UnorderedElementsAre()); // no-crash
} }
TEST(DiagnosticTest, ClangTidyMacroToEnumCheck) {
Annotations Main(R"cpp(
#if 1
auto foo();
#endif
)cpp");
TestTU TU = TestTU::withCode(Main.code());
std::vector<TidyProvider> Providers;
Providers.push_back(
addTidyChecks("cppcoreguidelines-macro-to-enum,modernize-macro-to-enum"));
Providers.push_back(disableUnusableChecks());
TU.ClangTidyProvider = combine(std::move(Providers));
EXPECT_THAT(TU.build().getDiagnostics(), UnorderedElementsAre()); // no-crash
}
TEST(DiagnosticTest, ElseAfterReturnRange) { TEST(DiagnosticTest, ElseAfterReturnRange) {
Annotations Main(R"cpp( Annotations Main(R"cpp(
int foo(int cond) { int foo(int cond) {