shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions 6 Packages Projects Releases Wiki Activity

[sanitizer] NFC: add static_assert to confirm that we use reasonable ByteMap type

Browse Source 
Summary: If bots work we can replace #ifs with template specialization by TwoLevelByteMapSize1.

There is known users of TwoLevelByteMap with TwoLevelByteMapSize1 equal 8,
and users of FlatByteMap with TwoLevelByteMapSize1 equal 2.

Reviewers: eugenis

Subscribers: kubamracek, #sanitizers, llvm-commits

Tags: #sanitizers, #llvm

Differential Revision: https://reviews.llvm.org/D61200

llvm-svn: 359364
This commit is contained in:
Vitaly Buka 2019-04-27 02:13:26 +00:00
parent 76c5b62988
commit 83c6d10b62
1 changed files with 21 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
compiler-rt/lib/sanitizer_common/sanitizer_allocator_primary32.h
View File

@ -45,8 +45,22 @@ struct SizeClassAllocator32FlagMasks { // Bit masks.
};
};
// This template is not necessary but t helps to see values if static_assert
// fails.
// FIXME: Replace check with automatic type detection. D61206
template <bool Expected, u64 MinSize, u64 ActualSize>
struct CheckTwoLevelByteMapSize {
static_assert((ActualSize >= MinSize) == Expected,
"Unexpected ByteMap type for the size");
};
template <class Params>
class SizeClassAllocator32 {
private:
static const u64 TwoLevelByteMapSize1 =
(Params::kSpaceSize >> Params::kRegionSizeLog) >> 12;
static const u64 kMinFirstMapSizeTwoLevelByteMap = 4;
public:
using AddressSpaceView = typename Params::AddressSpaceView;
static const uptr kSpaceBeg = Params::kSpaceBeg;
@ -58,12 +72,16 @@ class SizeClassAllocator32 {
typedef typename Params::MapUnmapCallback MapUnmapCallback;
#if SANITIZER_WORDSIZE == 32
CheckTwoLevelByteMapSize<false, kMinFirstMapSizeTwoLevelByteMap,
TwoLevelByteMapSize1>
Check;
using BM = FlatByteMap<(Params::kSpaceSize >> Params::kRegionSizeLog),
AddressSpaceView>;
#elif SANITIZER_WORDSIZE == 64
using BM =
TwoLevelByteMap<((Params::kSpaceSize >> Params::kRegionSizeLog) >> 12),
1 << 12, AddressSpaceView>;
CheckTwoLevelByteMapSize<true, kMinFirstMapSizeTwoLevelByteMap,
TwoLevelByteMapSize1>
Check;
using BM = TwoLevelByteMap<TwoLevelByteMapSize1, 1 << 12, AddressSpaceView>;
#endif
static_assert((Params::kFlags & SizeClassAllocator32FlagMasks::kForTest) ||
is_same<BM, ByteMap>::value,