shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions 6 Packages Projects Releases Wiki Activity

[Bolt] Replace -1ULL/-2ULL/-3ULL with std::numeric_limits in DataAggregator (#178597)

Browse Source 
Replace instances of -1ULL, -2ULL, and -3ULL with std::numeric_limits in
Bolt DataAggregator Trace constants to address C4146 compiler warning.

Changes:
- BR_ONLY: -1ULL → std::numeric_limits<uint64_t>::max()
- FT_ONLY: -1ULL → std::numeric_limits<uint64_t>::max()
- FT_EXTERNAL_ORIGIN: -2ULL → std::numeric_limits<uint64_t>::max() - 1
- FT_EXTERNAL_RETURN: -3ULL → std::numeric_limits<uint64_t>::max() - 2

Fixes part of #147439
This commit is contained in:
Devanshi 2026-02-09 11:34:11 +05:30 committed by GitHub
parent 355b676f2f
commit 8e02d249ba
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
bolt/include/bolt/Profile/DataAggregator.h
View File

@ -19,6 +19,7 @@
#include "llvm/ADT/StringRef.h"
#include "llvm/Support/Error.h"
#include "llvm/Support/Program.h"
#include <limits>
#include <unordered_map>
namespace llvm {
@ -108,10 +109,14 @@ private:
/// (FT_ONLY, FT_EXTERNAL_ORIGIN, or FT_EXTERNAL_RETURN).
struct Trace {
static constexpr const uint64_t EXTERNAL = 0ULL;
static constexpr const uint64_t BR_ONLY = -1ULL;
static constexpr const uint64_t FT_ONLY = -1ULL;
static constexpr const uint64_t FT_EXTERNAL_ORIGIN = -2ULL;
static constexpr const uint64_t FT_EXTERNAL_RETURN = -3ULL;
static constexpr const uint64_t BR_ONLY =
std::numeric_limits<uint64_t>::max();
static constexpr const uint64_t FT_ONLY =
std::numeric_limits<uint64_t>::max();
static constexpr const uint64_t FT_EXTERNAL_ORIGIN =
std::numeric_limits<uint64_t>::max() - 1;
static constexpr const uint64_t FT_EXTERNAL_RETURN =
std::numeric_limits<uint64_t>::max() - 2;
uint64_t Branch;
uint64_t From;