shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[llvm] Replace UndefValue::get with PoisonValue::get in a unit test [NFC] (#115985)

Browse Source 
Since these `UndefValue::get` are acted as placeholders, I think it's
safe to replace them with poison values.
There are a lot of `UndefValue::get` in LLVM, I'll start fixing the ones
in `unittests` while fixing the regression tests.
This commit is contained in:
Lee Wei 2024-11-13 01:01:53 -07:00 committed by GitHub
parent ae7b5af904
commit 91e134ad7d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
llvm/unittests/Analysis/PhiValuesTest.cpp
View File

@ -34,14 +34,14 @@ TEST(PhiValuesTest, SimplePhi) {
BasicBlock *If = BasicBlock::Create(C, "if", F);
BasicBlock *Else = BasicBlock::Create(C, "else", F);
BasicBlock *Then = BasicBlock::Create(C, "then", F);
BranchInst::Create(If, Else, UndefValue::get(I1Ty), Entry);
BranchInst::Create(If, Else, PoisonValue::get(I1Ty), Entry);
BranchInst::Create(Then, If);
BranchInst::Create(Then, Else);
Value *Val1 = new LoadInst(I32Ty, UndefValue::get(PtrTy), "val1", Entry);
Value *Val2 = new LoadInst(I32Ty, UndefValue::get(PtrTy), "val2", Entry);
Value *Val3 = new LoadInst(I32Ty, UndefValue::get(PtrTy), "val3", Entry);
Value *Val4 = new LoadInst(I32Ty, UndefValue::get(PtrTy), "val4", Entry);
Value *Val1 = new LoadInst(I32Ty, PoisonValue::get(PtrTy), "val1", Entry);
Value *Val2 = new LoadInst(I32Ty, PoisonValue::get(PtrTy), "val2", Entry);
Value *Val3 = new LoadInst(I32Ty, PoisonValue::get(PtrTy), "val3", Entry);
Value *Val4 = new LoadInst(I32Ty, PoisonValue::get(PtrTy), "val4", Entry);
PHINode *Phi1 = PHINode::Create(I32Ty, 2, "phi1", Then);
Phi1->addIncoming(Val1, If);
@ -104,17 +104,17 @@ TEST(PhiValuesTest, DependentPhi) {
BasicBlock *If2 = BasicBlock::Create(C, "if2", F);
BasicBlock *Else2 = BasicBlock::Create(C, "else2", F);
BasicBlock *End = BasicBlock::Create(C, "then", F);
BranchInst::Create(If1, Else1, UndefValue::get(I1Ty), Entry);
BranchInst::Create(If1, Else1, PoisonValue::get(I1Ty), Entry);
BranchInst::Create(Then, If1);
BranchInst::Create(Then, Else1);
BranchInst::Create(If2, Else2, UndefValue::get(I1Ty), Then);
BranchInst::Create(If2, Else2, PoisonValue::get(I1Ty), Then);
BranchInst::Create(End, If2);
BranchInst::Create(End, Else2);
Value *Val1 = new LoadInst(I32Ty, UndefValue::get(PtrTy), "val1", Entry);
Value *Val2 = new LoadInst(I32Ty, UndefValue::get(PtrTy), "val2", Entry);
Value *Val3 = new LoadInst(I32Ty, UndefValue::get(PtrTy), "val3", Entry);
Value *Val4 = new LoadInst(I32Ty, UndefValue::get(PtrTy), "val4", Entry);
Value *Val1 = new LoadInst(I32Ty, PoisonValue::get(PtrTy), "val1", Entry);
Value *Val2 = new LoadInst(I32Ty, PoisonValue::get(PtrTy), "val2", Entry);
Value *Val3 = new LoadInst(I32Ty, PoisonValue::get(PtrTy), "val3", Entry);
Value *Val4 = new LoadInst(I32Ty, PoisonValue::get(PtrTy), "val4", Entry);
PHINode *Phi1 = PHINode::Create(I32Ty, 2, "phi1", Then);
Phi1->addIncoming(Val1, If1);