shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[BOLT][NFC] Remove references to internal tasks

Browse Source 
(cherry picked from FBD32272387)
This commit is contained in:
Maksim Panchenko 2021-11-08 19:54:05 -08:00
parent 45f94abcd9
commit 933df2a460
4 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
bolt/lib/Core/BinaryContext.cpp
View File

@ -1016,7 +1016,7 @@ bool BinaryContext::setBinaryDataSize(uint64_t Address, uint64_t Size) {
// as a larger blob of private data. When we set the size of the
// jump table, it might be smaller than the total blob size. In this
// case we just leave the original size since (currently) it won't really
// affect anything. See T26915981.
// affect anything.
assert((!NI->second->Size || NI->second->Size == Size ||
(NI->second->isJumpTable() && NI->second->Size > Size)) &&
"can't change the size of a symbol that has already had its "

2
bolt/lib/Core/BinaryFunction.cpp
View File

@ -307,7 +307,7 @@ void BinaryFunction::markUnreachableBlocks() {
}
// FIXME:
// Also mark BBs with indirect jumps as reachable, since we do not
// support removing unused jump tables yet (T29418024 / GH-issue20)
// support removing unused jump tables yet (GH-issue20).
for (const MCInst &Inst : *BB) {
if (BC.MIB->getJumpTable(Inst)) {
Stack.push(BB);

2
bolt/lib/Passes/ReorderData.cpp
View File

@ -366,7 +366,7 @@ void ReorderData::setSectionOrder(BinaryContext &BC,
for (; Begin != End; ++Begin) {
BinaryData *BD = Begin->first;
// we can't move certain symbols because they are screwy, see T25076484.
// We can't move certain symbols.
if (!filterSymbol(BD))
continue;

8
bolt/lib/Target/X86/X86MCPlusBuilder.cpp
View File

@ -1751,9 +1751,9 @@ public:
static BitVector SPAliases(getAliases(X86::RSP));
// FIXME: PUSH can be technically a leak, but let's ignore this for now
// because a lot of harmless prologue code will spill SP to the stack
// (t15117648) - Unless push is clearly pushing an object address to the
// stack as demonstrated by having a MemOp.
// because a lot of harmless prologue code will spill SP to the stack.
// Unless push is clearly pushing an object address to the stack as
// demonstrated by having a MemOp.
bool IsPush = isPush(Inst);
if (IsPush && MemOpNo == -1)
return false;
@ -1762,7 +1762,7 @@ public:
bool AccessMem = MCII.mayLoad() || MCII.mayStore();
bool DoesLeak = false;
for (int I = 0, E = MCPlus::getNumPrimeOperands(Inst); I != E; ++I) {
// Ignore if SP/BP is used to derefence memory -- that's fine
// Ignore if SP/BP is used to dereference memory -- that's fine
if (MemOpNo != -1 && !IsPush && AccessMem && I >= MemOpNo &&
I <= MemOpNo + 5)
continue;