shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions 6 Packages Projects Releases Wiki Activity

[lldb] Fix UUID thombstone Key (#190551)

Browse Source 
This changes `DenseMapInfo<UUID>::getTombstoneKey()` to return a 1-byte
`{0xFF}` sentinel instead of the empty, default constructed UUID().
Returning the same key for the empty and tombstone value apparently
violates the `DenseMap` invariant.
This commit is contained in:
Jonas Devlieghere 2026-04-06 13:25:34 -07:00 committed by GitHub
parent 2aa4100fa7
commit 950f1de70b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lldb/include/lldb/Utility/UUID.h
View File

@ -112,6 +112,7 @@ private:
friend bool operator>=(const UUID &LHS, const UUID &RHS) {
return !(LHS < RHS);
}
friend struct llvm::DenseMapInfo<UUID>;
};
} // namespace lldb_private
@ -124,7 +125,9 @@ template <> struct DenseMapInfo<lldb_private::UUID> {
return lldb_private::UUID();
}
static inline lldb_private::UUID getTombstoneKey() {
return lldb_private::UUID();
lldb_private::UUID key;
key.m_bytes = {0xFF};
return key;
}
static unsigned getHashValue(lldb_private::UUID uuid) {
return DenseMapInfo<llvm::ArrayRef<uint8_t>>::getHashValue(uuid.GetBytes());