shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions 6 Packages Projects Releases Wiki Activity

[NFC][MLIR] Simplify lookup of nested symbols (#179362)

Browse Source 
Consolidate the handling of nested symbols in the loop over nested
references. This is an NFC refactor to make it simpler to enforce symbol
visibility here.
This commit is contained in:
neildhar 2026-02-03 09:34:08 -08:00 committed by GitHub
parent 294e43c72d
commit 9727cfe1fc
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 12 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
mlir/lib/IR/SymbolTable.cpp
View File

@ -413,30 +413,22 @@ static LogicalResult lookupSymbolInImpl(
assert(symbolTableOp->hasTrait<OpTrait::SymbolTable>());
// Lookup the root reference for this symbol.
symbolTableOp = lookupSymbolFn(symbolTableOp, symbol.getRootReference());
if (!symbolTableOp)
auto *symbolOp = lookupSymbolFn(symbolTableOp, symbol.getRootReference());
if (!symbolOp)
return failure();
symbols.push_back(symbolTableOp);
symbols.push_back(symbolOp);
// If there are no nested references, just return the root symbol directly.
ArrayRef<FlatSymbolRefAttr> nestedRefs = symbol.getNestedReferences();
if (nestedRefs.empty())
return success();
// Verify that the root is also a symbol table.
if (!symbolTableOp->hasTrait<OpTrait::SymbolTable>())
return failure();
// Otherwise, lookup each of the nested non-leaf references and ensure that
// each corresponds to a valid symbol table.
for (FlatSymbolRefAttr ref : nestedRefs.drop_back()) {
symbolTableOp = lookupSymbolFn(symbolTableOp, ref.getAttr());
if (!symbolTableOp || !symbolTableOp->hasTrait<OpTrait::SymbolTable>())
// Lookup each of the nested references.
for (FlatSymbolRefAttr ref : symbol.getNestedReferences()) {
// Check that we have a valid symbol table to lookup ref.
if (!symbolOp->hasTrait<OpTrait::SymbolTable>())
return failure();
symbols.push_back(symbolTableOp);
symbolOp = lookupSymbolFn(symbolOp, ref.getAttr());
if (!symbolOp)
return failure();
symbols.push_back(symbolOp);
}
symbols.push_back(lookupSymbolFn(symbolTableOp, symbol.getLeafReference()));
return success(symbols.back());
return success();
}
LogicalResult