shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions 6 Packages Projects Releases Wiki Activity

Fix emulated TLS alignment for large variables (#171037)

Browse Source 
Fix emulated TLS alignment for larger variables (>= 32 bytes) to use
preferred alignment.

Fixes #167219
This commit is contained in:
Medha Tiwari 2026-03-31 22:07:06 +05:30 committed by GitHub
parent c4e6cf0abf
commit 9c64cb6dca
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 23 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
llvm/lib/CodeGen/LowerEmuTLS.cpp
View File

@ -146,7 +146,7 @@ bool addEmuTlsVar(Module &M, const GlobalVariable *GV) {
return true;
Type *GVType = GV->getValueType();
Align GVAlignment = DL.getValueOrABITypeAlignment(GV->getAlign(), GVType);
Align GVAlignment = GV->getPointerAlignment(DL);
// Define "__emutls_t.*" if there is InitValue
GlobalVariable *EmuTlsTmplVar = nullptr;

4
llvm/test/CodeGen/AArch64/emutls.ll
View File

@ -175,7 +175,7 @@ entry:
; ARM64: .globl __emutls_v.s1
; ARM64-LABEL: __emutls_v.s1:
; ARM64-NEXT: .xword 2
; ARM64-NEXT: .xword 2
; ARM64-NEXT: .xword 4
; ARM64-NEXT: .xword 0
; ARM64-NEXT: .xword __emutls_t.s1
@ -186,7 +186,7 @@ entry:
; ARM64: .data{{$}}
; ARM64-LABEL: __emutls_v.b1:
; ARM64-NEXT: .xword 1
; ARM64-NEXT: .xword 1
; ARM64-NEXT: .xword 4
; ARM64-NEXT: .xword 0
; ARM64-NEXT: .xword 0

20
llvm/test/CodeGen/ARM/emutls-alignment.ll Normal file
View File

@ -0,0 +1,20 @@
; RUN: llc -emulated-tls -mtriple=armv7-linux-android -relocation-model=pic < %s | FileCheck %s
; Test that emulated TLS uses preferred alignment for variables.
; This fixes a bug where emutls would use lower alignment than expected
; by the code generator, causing crashes with vectorized accesses.
; Fixes https://github.com/llvm/llvm-project/issues/167219
; A 64-byte array should get 16-byte alignment (preferred for ARM NEON).
@large_array = internal thread_local global [64 x i8] c"AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA"
define ptr @get_large_array() {
entry:
ret ptr @large_array
}
; CHECK-LABEL: __emutls_v.large_array:
; CHECK-NEXT: .long 64
; CHECK-NEXT: .long 16
; CHECK-NEXT: .long 0
; CHECK-NEXT: .long __emutls_t.large_array