shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[libc][math] Refactor coshf implementation to header-only in src/__support/math folder. (#153427)

Browse Source 
Part of #147386

in preparation for:
https://discourse.llvm.org/t/rfc-make-clang-builtin-math-functions-constexpr-with-llvm-libc-to-support-c-23-constexpr-math-functions/86450
This commit is contained in:
Muhammad Bassiouni 2025-08-14 17:19:47 +03:00 committed by GitHub
parent 63e7766047
commit 9ddc85f6d5
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
19 changed files with 174 additions and 137 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
libc/shared/math.h
View File

@ -35,6 +35,7 @@
#include "math/cos.h" #include "math/cos.h"
#include "math/cosf.h" #include "math/cosf.h"
#include "math/cosf16.h" #include "math/cosf16.h"
#include "math/coshf.h"
#include "math/erff.h" #include "math/erff.h"
#include "math/exp.h" #include "math/exp.h"
#include "math/exp10.h" #include "math/exp10.h"

23
libc/shared/math/coshf.h Normal file
View File

@ -0,0 +1,23 @@
//===-- Shared coshf function -----------------------------------*- C++ -*-===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#ifndef LLVM_LIBC_SHARED_MATH_COSHF_H
#define LLVM_LIBC_SHARED_MATH_COSHF_H
#include "shared/libc_common.h"
#include "src/__support/math/coshf.h"
namespace LIBC_NAMESPACE_DECL {
namespace shared {
using math::coshf;
} // namespace shared
} // namespace LIBC_NAMESPACE_DECL
#endif // LLVM_LIBC_SHARED_MATH_COSHF_H

21
libc/src/__support/math/CMakeLists.txt
View File

@ -407,6 +407,18 @@ add_header_library(
libc.src.__support.macros.properties.types libc.src.__support.macros.properties.types
) )
add_header_library(
coshf
HDRS
coshf.h
DEPENDS
.sinhfcoshf_utils
libc.src.__support.FPUtil.fp_bits
libc.src.__support.FPUtil.multiply_add
libc.src.__support.FPUtil.rounding_mode
libc.src.__support.macros.optimization
)
add_header_library( add_header_library(
erff erff
HDRS HDRS
@ -726,3 +738,12 @@ add_header_library(
libc.src.__support.FPUtil.nearest_integer libc.src.__support.FPUtil.nearest_integer
libc.src.__support.common libc.src.__support.common
) )
add_header_library(
sinhfcoshf_utils
HDRS
sinhfcoshf_utils.h
DEPENDS
.exp10f_utils
libc.src.__support.FPUtil.multiply_add
)

65
libc/src/__support/math/coshf.h Normal file
View File

@ -0,0 +1,65 @@
//===-- Implementation header for coshf -------------------------*- C++ -*-===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#ifndef LLVM_LIBC_SRC___SUPPORT_MATH_COSHF_H
#define LLVM_LIBC_SRC___SUPPORT_MATH_COSHF_H
#include "sinhfcoshf_utils.h"
#include "src/__support/FPUtil/FEnvImpl.h"
#include "src/__support/FPUtil/FPBits.h"
#include "src/__support/FPUtil/rounding_mode.h"
#include "src/__support/macros/config.h"
#include "src/__support/macros/optimization.h" // LIBC_UNLIKELY
namespace LIBC_NAMESPACE_DECL {
namespace math {
LIBC_INLINE static constexpr float coshf(float x) {
using namespace sinhfcoshf_internal;
using FPBits = typename fputil::FPBits<float>;
FPBits xbits(x);
xbits.set_sign(Sign::POS);
x = xbits.get_val();
uint32_t x_u = xbits.uintval();
// When |x| >= 90, or x is inf or nan
if (LIBC_UNLIKELY(x_u >= 0x42b4'0000U || x_u <= 0x3280'0000U)) {
// |x| <= 2^-26
if (x_u <= 0x3280'0000U) {
return 1.0f + x;
}
if (xbits.is_inf_or_nan())
return x + FPBits::inf().get_val();
int rounding = fputil::quick_get_round();
if (LIBC_UNLIKELY(rounding == FE_DOWNWARD || rounding == FE_TOWARDZERO))
return FPBits::max_normal().get_val();
fputil::set_errno_if_required(ERANGE);
fputil::raise_except_if_required(FE_OVERFLOW);
return x + FPBits::inf().get_val();
}
// TODO: We should be able to reduce the latency and reciprocal throughput
// further by using a low degree (maybe 3-7 ?) minimax polynomial for small
// but not too small inputs, such as |x| < 2^-2, or |x| < 2^-3.
// cosh(x) = (e^x + e^(-x)) / 2.
return static_cast<float>(exp_pm_eval</*is_sinh*/ false>(x));
}
} // namespace math
} // namespace LIBC_NAMESPACE_DECL
#endif // LLVM_LIBC_SRC___SUPPORT_MATH_COSHF_H

26
libc/src/math/generic/explogxf.h → libc/src/__support/math/sinhfcoshf_utils.h
View File

@ -1,4 +1,4 @@
//===-- Single-precision general exp/log functions ------------------------===// //===-- Single-precision general sinhf/coshf functions --------------------===//
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
@ -6,21 +6,17 @@
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#ifndef LLVM_LIBC_SRC_MATH_GENERIC_EXPLOGXF_H #ifndef LLVM_LIBC_SRC___SUPPORT_MATH_SINHFCOSHF_UTILS_H
#define LLVM_LIBC_SRC_MATH_GENERIC_EXPLOGXF_H #define LLVM_LIBC_SRC___SUPPORT_MATH_SINHFCOSHF_UTILS_H
#include "common_constants.h" #include "exp10f_utils.h"
#include "src/__support/FPUtil/multiply_add.h"
#include "src/__support/common.h"
#include "src/__support/macros/properties/cpu_features.h"
#include "src/__support/math/acoshf_utils.h"
#include "src/__support/math/exp10f_utils.h"
#include "src/__support/math/exp_utils.h"
namespace LIBC_NAMESPACE_DECL { namespace LIBC_NAMESPACE_DECL {
constexpr int LOG_P1_BITS = 6; namespace math {
constexpr int LOG_P1_SIZE = 1 << LOG_P1_BITS;
namespace sinhfcoshf_internal {
// The function correctly calculates sinh(x) and cosh(x) by calculating exp(x) // The function correctly calculates sinh(x) and cosh(x) by calculating exp(x)
// and exp(-x) simultaneously. // and exp(-x) simultaneously.
@ -121,6 +117,10 @@ template <bool is_sinh> LIBC_INLINE double exp_pm_eval(float x) {
return r; return r;
} }
} // namespace sinhfcoshf_internal
} // namespace math
} // namespace LIBC_NAMESPACE_DECL } // namespace LIBC_NAMESPACE_DECL
#endif // LLVM_LIBC_SRC_MATH_GENERIC_EXPLOGXF_H #endif // LLVM_LIBC_SRC___SUPPORT_MATH_SINHFCOSHF_UTILS_H

38
libc/src/math/generic/CMakeLists.txt
View File

@ -1344,7 +1344,6 @@ add_entrypoint_object(
../exp2.h ../exp2.h
DEPENDS DEPENDS
.common_constants .common_constants
.explogxf
libc.src.__support.CPP.bit libc.src.__support.CPP.bit
libc.src.__support.CPP.optional libc.src.__support.CPP.optional
libc.src.__support.FPUtil.dyadic_float libc.src.__support.FPUtil.dyadic_float
@ -1357,6 +1356,7 @@ add_entrypoint_object(
libc.src.__support.FPUtil.triple_double libc.src.__support.FPUtil.triple_double
libc.src.__support.integer_literals libc.src.__support.integer_literals
libc.src.__support.macros.optimization libc.src.__support.macros.optimization
libc.src.__support.math.exp_utils
libc.src.errno.errno libc.src.errno.errno
) )
@ -1365,7 +1365,6 @@ add_header_library(
HDRS HDRS
exp2f_impl.h exp2f_impl.h
DEPENDS DEPENDS
.explogxf
libc.src.__support.FPUtil.except_value_utils libc.src.__support.FPUtil.except_value_utils
libc.src.__support.FPUtil.fenv_impl libc.src.__support.FPUtil.fenv_impl
libc.src.__support.FPUtil.fp_bits libc.src.__support.FPUtil.fp_bits
@ -1374,6 +1373,7 @@ add_header_library(
libc.src.__support.FPUtil.polyeval libc.src.__support.FPUtil.polyeval
libc.src.__support.FPUtil.rounding_mode libc.src.__support.FPUtil.rounding_mode
libc.src.__support.macros.optimization libc.src.__support.macros.optimization
libc.src.__support.math.exp10f_utils
libc.src.__support.common libc.src.__support.common
libc.src.errno.errno libc.src.errno.errno
) )
@ -1413,7 +1413,6 @@ add_entrypoint_object(
HDRS HDRS
../exp2m1f.h ../exp2m1f.h
DEPENDS DEPENDS
.explogxf
libc.src.errno.errno libc.src.errno.errno
libc.src.__support.common libc.src.__support.common
libc.src.__support.FPUtil.except_value_utils libc.src.__support.FPUtil.except_value_utils
@ -1424,6 +1423,7 @@ add_entrypoint_object(
libc.src.__support.FPUtil.rounding_mode libc.src.__support.FPUtil.rounding_mode
libc.src.__support.macros.optimization libc.src.__support.macros.optimization
libc.src.__support.macros.properties.cpu_features libc.src.__support.macros.properties.cpu_features
libc.src.__support.math.exp10f_utils
) )
add_entrypoint_object( add_entrypoint_object(
@ -1488,7 +1488,6 @@ add_entrypoint_object(
HDRS HDRS
../exp10m1f.h ../exp10m1f.h
DEPENDS DEPENDS
.explogxf
libc.src.errno.errno libc.src.errno.errno
libc.src.__support.common libc.src.__support.common
libc.src.__support.FPUtil.except_value_utils libc.src.__support.FPUtil.except_value_utils
@ -1498,6 +1497,7 @@ add_entrypoint_object(
libc.src.__support.FPUtil.polyeval libc.src.__support.FPUtil.polyeval
libc.src.__support.FPUtil.rounding_mode libc.src.__support.FPUtil.rounding_mode
libc.src.__support.macros.optimization libc.src.__support.macros.optimization
libc.src.__support.math.exp10f_utils
) )
add_entrypoint_object( add_entrypoint_object(
@ -1529,14 +1529,11 @@ add_entrypoint_object(
../expm1.h ../expm1.h
DEPENDS DEPENDS
.common_constants .common_constants
.explogxf
libc.src.__support.CPP.bit libc.src.__support.CPP.bit
libc.src.__support.CPP.optional
libc.src.__support.FPUtil.dyadic_float libc.src.__support.FPUtil.dyadic_float
libc.src.__support.FPUtil.fenv_impl libc.src.__support.FPUtil.fenv_impl
libc.src.__support.FPUtil.fp_bits libc.src.__support.FPUtil.fp_bits
libc.src.__support.FPUtil.multiply_add libc.src.__support.FPUtil.multiply_add
libc.src.__support.FPUtil.nearest_integer
libc.src.__support.FPUtil.polyeval libc.src.__support.FPUtil.polyeval
libc.src.__support.FPUtil.rounding_mode libc.src.__support.FPUtil.rounding_mode
libc.src.__support.FPUtil.triple_double libc.src.__support.FPUtil.triple_double
@ -1593,7 +1590,6 @@ add_entrypoint_object(
DEPENDS DEPENDS
.common_constants .common_constants
.exp2f_impl .exp2f_impl
.explogxf
libc.src.__support.math.exp10f libc.src.__support.math.exp10f
libc.src.__support.CPP.bit libc.src.__support.CPP.bit
libc.src.__support.FPUtil.fenv_impl libc.src.__support.FPUtil.fenv_impl
@ -3905,19 +3901,6 @@ add_entrypoint_object(
libc.src.__support.FPUtil.nearest_integer_operations libc.src.__support.FPUtil.nearest_integer_operations
) )
#TODO: Add errno include to the hyperbolic functions.
add_header_library(
explogxf
HDRS
explogxf.h
DEPENDS
.common_constants
libc.src.__support.math.exp_utils
libc.src.__support.math.acoshf_utils
libc.src.__support.macros.properties.cpu_features
libc.src.errno.errno
)
add_entrypoint_object( add_entrypoint_object(
coshf coshf
SRCS SRCS
@ -3925,11 +3908,7 @@ add_entrypoint_object(
HDRS HDRS
../coshf.h ../coshf.h
DEPENDS DEPENDS
.explogxf libc.src.__support.math.coshf
libc.src.__support.FPUtil.fp_bits
libc.src.__support.FPUtil.multiply_add
libc.src.__support.FPUtil.rounding_mode
libc.src.__support.macros.optimization
) )
add_entrypoint_object( add_entrypoint_object(
@ -3956,10 +3935,10 @@ add_entrypoint_object(
HDRS HDRS
../sinhf.h ../sinhf.h
DEPENDS DEPENDS
.explogxf
libc.src.__support.FPUtil.fp_bits libc.src.__support.FPUtil.fp_bits
libc.src.__support.FPUtil.rounding_mode libc.src.__support.FPUtil.rounding_mode
libc.src.__support.macros.optimization libc.src.__support.macros.optimization
libc.src.__support.math.sinhfcoshf_utils
) )
add_entrypoint_object( add_entrypoint_object(
@ -3973,7 +3952,7 @@ add_entrypoint_object(
libc.hdr.errno_macros libc.hdr.errno_macros
libc.hdr.fenv_macros libc.hdr.fenv_macros
libc.src.__support.FPUtil.except_value_utils libc.src.__support.FPUtil.except_value_utils
libc.src.__support.FPUtil.fenv_impl libc.src.__support.FPUtil.fenv_impl
libc.src.__support.FPUtil.fp_bits libc.src.__support.FPUtil.fp_bits
libc.src.__support.FPUtil.rounding_mode libc.src.__support.FPUtil.rounding_mode
libc.src.__support.macros.optimization libc.src.__support.macros.optimization
@ -3986,12 +3965,12 @@ add_entrypoint_object(
HDRS HDRS
../tanhf.h ../tanhf.h
DEPENDS DEPENDS
.explogxf
libc.src.__support.FPUtil.fp_bits libc.src.__support.FPUtil.fp_bits
libc.src.__support.FPUtil.rounding_mode libc.src.__support.FPUtil.rounding_mode
libc.src.__support.FPUtil.multiply_add libc.src.__support.FPUtil.multiply_add
libc.src.__support.FPUtil.polyeval libc.src.__support.FPUtil.polyeval
libc.src.__support.macros.optimization libc.src.__support.macros.optimization
libc.src.__support.math.exp10f_utils
) )
add_entrypoint_object( add_entrypoint_object(
@ -4022,7 +4001,6 @@ add_entrypoint_object(
HDRS HDRS
../acoshf.h ../acoshf.h
DEPENDS DEPENDS
.explogxf
libc.src.__support.math.acoshf libc.src.__support.math.acoshf
) )

1
libc/src/math/generic/acoshf.cpp
View File

@ -7,7 +7,6 @@
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#include "src/math/acoshf.h" #include "src/math/acoshf.h"
#include "src/__support/math/acoshf.h" #include "src/__support/math/acoshf.h"
namespace LIBC_NAMESPACE_DECL { namespace LIBC_NAMESPACE_DECL {

44
libc/src/math/generic/coshf.cpp
View File

@ -7,50 +7,10 @@
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#include "src/math/coshf.h" #include "src/math/coshf.h"
#include "src/__support/FPUtil/FEnvImpl.h" #include "src/__support/math/coshf.h"
#include "src/__support/FPUtil/FPBits.h"
#include "src/__support/FPUtil/rounding_mode.h"
#include "src/__support/macros/config.h"
#include "src/__support/macros/optimization.h" // LIBC_UNLIKELY
#include "src/math/generic/explogxf.h"
namespace LIBC_NAMESPACE_DECL { namespace LIBC_NAMESPACE_DECL {
LLVM_LIBC_FUNCTION(float, coshf, (float x)) { LLVM_LIBC_FUNCTION(float, coshf, (float x)) { return math::coshf(x); }
using FPBits = typename fputil::FPBits<float>;
FPBits xbits(x);
xbits.set_sign(Sign::POS);
x = xbits.get_val();
uint32_t x_u = xbits.uintval();
// When |x| >= 90, or x is inf or nan
if (LIBC_UNLIKELY(x_u >= 0x42b4'0000U || x_u <= 0x3280'0000U)) {
// |x| <= 2^-26
if (x_u <= 0x3280'0000U) {
return 1.0f + x;
}
if (xbits.is_inf_or_nan())
return x + FPBits::inf().get_val();
int rounding = fputil::quick_get_round();
if (LIBC_UNLIKELY(rounding == FE_DOWNWARD || rounding == FE_TOWARDZERO))
return FPBits::max_normal().get_val();
fputil::set_errno_if_required(ERANGE);
fputil::raise_except_if_required(FE_OVERFLOW);
return x + FPBits::inf().get_val();
}
// TODO: We should be able to reduce the latency and reciprocal throughput
// further by using a low degree (maybe 3-7 ?) minimax polynomial for small
// but not too small inputs, such as |x| < 2^-2, or |x| < 2^-3.
// cosh(x) = (e^x + e^(-x)) / 2.
return static_cast<float>(exp_pm_eval</*is_sinh*/ false>(x));
}
} // namespace LIBC_NAMESPACE_DECL } // namespace LIBC_NAMESPACE_DECL

3
libc/src/math/generic/exp10m1f.cpp
View File

@ -17,8 +17,7 @@
#include "src/__support/libc_errno.h" #include "src/__support/libc_errno.h"
#include "src/__support/macros/config.h" #include "src/__support/macros/config.h"
#include "src/__support/macros/optimization.h" #include "src/__support/macros/optimization.h"
#include "src/__support/math/exp10f_utils.h"
#include "explogxf.h"
namespace LIBC_NAMESPACE_DECL { namespace LIBC_NAMESPACE_DECL {

2
libc/src/math/generic/exp2.cpp
View File

@ -8,7 +8,6 @@
#include "src/math/exp2.h" #include "src/math/exp2.h"
#include "common_constants.h" // Lookup tables EXP2_MID1 and EXP_M2. #include "common_constants.h" // Lookup tables EXP2_MID1 and EXP_M2.
#include "explogxf.h" // ziv_test_denorm.
#include "src/__support/CPP/bit.h" #include "src/__support/CPP/bit.h"
#include "src/__support/CPP/optional.h" #include "src/__support/CPP/optional.h"
#include "src/__support/FPUtil/FEnvImpl.h" #include "src/__support/FPUtil/FEnvImpl.h"
@ -24,6 +23,7 @@
#include "src/__support/integer_literals.h" #include "src/__support/integer_literals.h"
#include "src/__support/macros/config.h" #include "src/__support/macros/config.h"
#include "src/__support/macros/optimization.h" // LIBC_UNLIKELY #include "src/__support/macros/optimization.h" // LIBC_UNLIKELY
#include "src/__support/math/exp_utils.h" // ziv_test_denorm.
namespace LIBC_NAMESPACE_DECL { namespace LIBC_NAMESPACE_DECL {

3
libc/src/math/generic/exp2f_impl.h
View File

@ -20,8 +20,7 @@
#include "src/__support/macros/config.h" #include "src/__support/macros/config.h"
#include "src/__support/macros/optimization.h" // LIBC_UNLIKELY #include "src/__support/macros/optimization.h" // LIBC_UNLIKELY
#include "src/__support/macros/properties/cpu_features.h" #include "src/__support/macros/properties/cpu_features.h"
#include "src/__support/math/exp10f_utils.h"
#include "explogxf.h"
namespace LIBC_NAMESPACE_DECL { namespace LIBC_NAMESPACE_DECL {
namespace generic { namespace generic {

3
libc/src/math/generic/exp2m1f.cpp
View File

@ -18,8 +18,7 @@
#include "src/__support/macros/config.h" #include "src/__support/macros/config.h"
#include "src/__support/macros/optimization.h" #include "src/__support/macros/optimization.h"
#include "src/__support/macros/properties/cpu_features.h" #include "src/__support/macros/properties/cpu_features.h"
#include "src/__support/math/exp10f_utils.h"
#include "explogxf.h"
namespace LIBC_NAMESPACE_DECL { namespace LIBC_NAMESPACE_DECL {

3
libc/src/math/generic/expm1.cpp
View File

@ -8,9 +8,7 @@
#include "src/math/expm1.h" #include "src/math/expm1.h"
#include "common_constants.h" // Lookup tables EXP_M1 and EXP_M2. #include "common_constants.h" // Lookup tables EXP_M1 and EXP_M2.
#include "explogxf.h" // ziv_test_denorm.
#include "src/__support/CPP/bit.h" #include "src/__support/CPP/bit.h"
#include "src/__support/CPP/optional.h"
#include "src/__support/FPUtil/FEnvImpl.h" #include "src/__support/FPUtil/FEnvImpl.h"
#include "src/__support/FPUtil/FPBits.h" #include "src/__support/FPUtil/FPBits.h"
#include "src/__support/FPUtil/PolyEval.h" #include "src/__support/FPUtil/PolyEval.h"
@ -18,7 +16,6 @@
#include "src/__support/FPUtil/dyadic_float.h" #include "src/__support/FPUtil/dyadic_float.h"
#include "src/__support/FPUtil/except_value_utils.h" #include "src/__support/FPUtil/except_value_utils.h"
#include "src/__support/FPUtil/multiply_add.h" #include "src/__support/FPUtil/multiply_add.h"
#include "src/__support/FPUtil/nearest_integer.h"
#include "src/__support/FPUtil/rounding_mode.h" #include "src/__support/FPUtil/rounding_mode.h"
#include "src/__support/FPUtil/triple_double.h" #include "src/__support/FPUtil/triple_double.h"
#include "src/__support/common.h" #include "src/__support/common.h"

5
libc/src/math/generic/sinhf.cpp
View File

@ -12,7 +12,7 @@
#include "src/__support/FPUtil/rounding_mode.h" #include "src/__support/FPUtil/rounding_mode.h"
#include "src/__support/macros/config.h" #include "src/__support/macros/config.h"
#include "src/__support/macros/optimization.h" // LIBC_UNLIKELY #include "src/__support/macros/optimization.h" // LIBC_UNLIKELY
#include "src/math/generic/explogxf.h" #include "src/__support/math/sinhfcoshf_utils.h"
namespace LIBC_NAMESPACE_DECL { namespace LIBC_NAMESPACE_DECL {
@ -73,7 +73,8 @@ LLVM_LIBC_FUNCTION(float, sinhf, (float x)) {
} }
// sinh(x) = (e^x - e^(-x)) / 2. // sinh(x) = (e^x - e^(-x)) / 2.
return static_cast<float>(exp_pm_eval</*is_sinh*/ true>(x)); return static_cast<float>(
math::sinhfcoshf_internal::exp_pm_eval</*is_sinh*/ true>(x));
} }
} // namespace LIBC_NAMESPACE_DECL } // namespace LIBC_NAMESPACE_DECL

2
libc/src/math/generic/tanhf.cpp
View File

@ -14,7 +14,7 @@
#include "src/__support/macros/config.h" #include "src/__support/macros/config.h"
#include "src/__support/macros/optimization.h" // LIBC_UNLIKELY #include "src/__support/macros/optimization.h" // LIBC_UNLIKELY
#include "src/__support/macros/properties/cpu_features.h" #include "src/__support/macros/properties/cpu_features.h"
#include "src/math/generic/explogxf.h" #include "src/__support/math/exp10f_utils.h"
namespace LIBC_NAMESPACE_DECL { namespace LIBC_NAMESPACE_DECL {

1
libc/test/shared/CMakeLists.txt
View File

@ -31,6 +31,7 @@ add_fp_unittest(
libc.src.__support.math.cos libc.src.__support.math.cos
libc.src.__support.math.cosf libc.src.__support.math.cosf
libc.src.__support.math.cosf16 libc.src.__support.math.cosf16
libc.src.__support.math.coshf
libc.src.__support.math.erff libc.src.__support.math.erff
libc.src.__support.math.exp libc.src.__support.math.exp
libc.src.__support.math.exp10 libc.src.__support.math.exp10

1
libc/test/shared/shared_math_test.cpp
View File

@ -51,6 +51,7 @@ TEST(LlvmLibcSharedMathTest, AllFloat) {
EXPECT_FP_EQ(0x0p+0f, LIBC_NAMESPACE::shared::atanhf(0.0f)); EXPECT_FP_EQ(0x0p+0f, LIBC_NAMESPACE::shared::atanhf(0.0f));
EXPECT_FP_EQ(0x0p+0f, LIBC_NAMESPACE::shared::cbrtf(0.0f)); EXPECT_FP_EQ(0x0p+0f, LIBC_NAMESPACE::shared::cbrtf(0.0f));
EXPECT_FP_EQ(0x1p+0f, LIBC_NAMESPACE::shared::cosf(0.0f)); EXPECT_FP_EQ(0x1p+0f, LIBC_NAMESPACE::shared::cosf(0.0f));
EXPECT_FP_EQ(0x1p+0f, LIBC_NAMESPACE::shared::coshf(0.0f));
EXPECT_FP_EQ(0x0p+0f, LIBC_NAMESPACE::shared::erff(0.0f)); EXPECT_FP_EQ(0x0p+0f, LIBC_NAMESPACE::shared::erff(0.0f));
EXPECT_FP_EQ(0x1p+0f, LIBC_NAMESPACE::shared::exp10f(0.0f)); EXPECT_FP_EQ(0x1p+0f, LIBC_NAMESPACE::shared::exp10f(0.0f));
EXPECT_FP_EQ(0x1p+0f, LIBC_NAMESPACE::shared::expf(0.0f)); EXPECT_FP_EQ(0x1p+0f, LIBC_NAMESPACE::shared::expf(0.0f));

4
libc/test/src/math/explogxf_test.cpp
View File

@ -9,11 +9,11 @@
#include "hdr/math_macros.h" #include "hdr/math_macros.h"
#include "in_float_range_test_helper.h" #include "in_float_range_test_helper.h"
#include "src/__support/FPUtil/FPBits.h" #include "src/__support/FPUtil/FPBits.h"
#include "src/__support/math/acoshf_utils.h"
#include "src/__support/math/exp10f_utils.h"
#include "src/math/fabs.h" #include "src/math/fabs.h"
#include "src/math/fabsf.h" #include "src/math/fabsf.h"
#include "src/math/generic/explogxf.h"
#include "test/UnitTest/FPMatcher.h" #include "test/UnitTest/FPMatcher.h"
#include "test/UnitTest/Test.h"
#include "utils/MPFRWrapper/MPFRUtils.h" #include "utils/MPFRWrapper/MPFRUtils.h"
using LlvmLibcExplogfTest = LIBC_NAMESPACE::testing::FPTest<float>; using LlvmLibcExplogfTest = LIBC_NAMESPACE::testing::FPTest<float>;

65
utils/bazel/llvm-project-overlay/libc/BUILD.bazel
View File

@ -1953,22 +1953,6 @@ libc_support_library(
], ],
) )
libc_support_library(
name = "explogxf",
hdrs = ["src/math/generic/explogxf.h"],
deps = [
":__support_fputil_fenv_impl",
":__support_fputil_fma",
":__support_fputil_multiply_add",
":__support_fputil_nearest_integer",
":__support_macros_properties_cpu_features",
":__support_math_acoshf_utils",
":__support_math_exp10f_utils",
":__support_math_exp_utils",
":common_constants",
],
)
libc_support_library( libc_support_library(
name = "log_range_reduction", name = "log_range_reduction",
hdrs = ["src/math/generic/log_range_reduction.h"], hdrs = ["src/math/generic/log_range_reduction.h"],
@ -1991,8 +1975,8 @@ libc_support_library(
":__support_fputil_polyeval", ":__support_fputil_polyeval",
":__support_fputil_rounding_mode", ":__support_fputil_rounding_mode",
":__support_macros_optimization", ":__support_macros_optimization",
":__support_math_exp10f_utils",
":common_constants", ":common_constants",
":explogxf",
], ],
) )
@ -2394,6 +2378,18 @@ libc_support_library(
], ],
) )
libc_support_library(
name = "__support_math_coshf",
hdrs = ["src/__support/math/coshf.h"],
deps = [
":__support_fputil_fp_bits",
":__support_fputil_multiply_add",
":__support_fputil_rounding_mode",
":__support_macros_optimization",
":__support_math_sinhfcoshf_utils",
],
)
libc_support_library( libc_support_library(
name = "__support_math_erff", name = "__support_math_erff",
hdrs = ["src/__support/math/erff.h"], hdrs = ["src/__support/math/erff.h"],
@ -2718,6 +2714,15 @@ libc_support_library(
], ],
) )
libc_support_library(
name = "__support_math_sinhfcoshf_utils",
hdrs = ["src/__support/math/sinhfcoshf_utils.h"],
deps = [
":__support_math_exp10f_utils",
":__support_fputil_multiply_add",
],
)
############################### complex targets ################################ ############################### complex targets ################################
libc_function( libc_function(
@ -2989,7 +2994,6 @@ libc_math_function(
name = "acoshf", name = "acoshf",
additional_deps = [ additional_deps = [
":__support_math_acoshf", ":__support_math_acoshf",
":explogxf",
], ],
) )
@ -3188,14 +3192,7 @@ libc_math_function(
libc_math_function( libc_math_function(
name = "coshf", name = "coshf",
additional_deps = [ additional_deps = [
":__support_fputil_fma", ":__support_math_coshf",
":__support_fputil_multiply_add",
":__support_fputil_nearest_integer",
":__support_fputil_polyeval",
":__support_fputil_rounding_mode",
":__support_macros_optimization",
":common_constants",
":explogxf",
], ],
) )
@ -3215,9 +3212,8 @@ libc_math_function(
":__support_fputil_polyeval", ":__support_fputil_polyeval",
":__support_fputil_rounding_mode", ":__support_fputil_rounding_mode",
":__support_macros_optimization", ":__support_macros_optimization",
":common_constants",
":explogxf",
":__support_sincosf_utils", ":__support_sincosf_utils",
":common_constants",
], ],
) )
@ -3339,7 +3335,7 @@ libc_math_function(
libc_math_function( libc_math_function(
name = "exp10m1f", name = "exp10m1f",
additional_deps = [ additional_deps = [
":explogxf", ":__support_math_exp10f_utils",
], ],
) )
@ -3355,8 +3351,8 @@ libc_math_function(
":__support_fputil_triple_double", ":__support_fputil_triple_double",
":__support_integer_literals", ":__support_integer_literals",
":__support_macros_optimization", ":__support_macros_optimization",
":__support_math_exp_utils",
":common_constants", ":common_constants",
":explogxf",
], ],
) )
@ -3378,7 +3374,7 @@ libc_math_function(
name = "exp2m1f", name = "exp2m1f",
additional_deps = [ additional_deps = [
":__support_fputil_polyeval", ":__support_fputil_polyeval",
":explogxf", ":__support_math_exp10f_utils",
], ],
) )
@ -3395,14 +3391,12 @@ libc_math_function(
":__support_fputil_double_double", ":__support_fputil_double_double",
":__support_fputil_dyadic_float", ":__support_fputil_dyadic_float",
":__support_fputil_multiply_add", ":__support_fputil_multiply_add",
":__support_fputil_nearest_integer",
":__support_fputil_polyeval", ":__support_fputil_polyeval",
":__support_fputil_rounding_mode", ":__support_fputil_rounding_mode",
":__support_fputil_triple_double", ":__support_fputil_triple_double",
":__support_integer_literals", ":__support_integer_literals",
":__support_macros_optimization", ":__support_macros_optimization",
":common_constants", ":common_constants",
":explogxf",
], ],
) )
@ -4180,7 +4174,6 @@ libc_math_function(
":__support_macros_optimization", ":__support_macros_optimization",
":__support_math_exp10f", ":__support_math_exp10f",
":common_constants", ":common_constants",
":explogxf",
":exp2f_impl", ":exp2f_impl",
], ],
) )
@ -4340,8 +4333,8 @@ libc_math_function(
":__support_fputil_polyeval", ":__support_fputil_polyeval",
":__support_fputil_rounding_mode", ":__support_fputil_rounding_mode",
":__support_macros_optimization", ":__support_macros_optimization",
":__support_math_sinhfcoshf_utils",
":common_constants", ":common_constants",
":explogxf",
], ],
) )
@ -4447,8 +4440,8 @@ libc_math_function(
":__support_fputil_rounding_mode", ":__support_fputil_rounding_mode",
":__support_macros_optimization", ":__support_macros_optimization",
":__support_macros_properties_cpu_features", ":__support_macros_properties_cpu_features",
":__support_math_exp10f_utils",
":common_constants", ":common_constants",
":explogxf",
], ],
) )