From 9ea1d39eadebeef0decd5505d07b2f186bce8722 Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Fri, 8 Aug 2025 15:59:15 +0000 Subject: [PATCH] [CI][Github] Remove Outdated Comments 5fc3e76ec4f323c22cddf7b9458137510507847a made the pipelines fail on errors and also removed the TODO comments, but did not remove the explanatory comments on why things were set up that way. Given things no longer succeed on error, these comments are outdated and should be removed. --- .github/workflows/premerge.yaml | 6 ------ 1 file changed, 6 deletions(-) diff --git a/.github/workflows/premerge.yaml b/.github/workflows/premerge.yaml index d0518fa6879e..6e59841e9136 100644 --- a/.github/workflows/premerge.yaml +++ b/.github/workflows/premerge.yaml @@ -35,9 +35,6 @@ jobs: with: fetch-depth: 2 - name: Build and Test - # Mark the job as a success even if the step fails so that people do - # not get notified while the new premerge pipeline is in an - # experimental state. run: | git config --global --add safe.directory '*' @@ -109,9 +106,6 @@ jobs: echo "windows-projects=${projects_to_build}" >> $GITHUB_OUTPUT echo "windows-check-targets=${project_check_targets}" >> $GITHUB_OUTPUT - name: Build and Test - # Mark the job as a success even if the step fails so that people do - # not get notified while the new premerge pipeline is in an - # experimental state. if: ${{ steps.vars.outputs.windows-projects != '' }} shell: cmd run: |