shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[ARM] Improve arm_neon.h header diagnostic when included on unsupported targets (#147817)

Browse Source 
The footgun here was that the preprocessor diagnostic that looks for
__ARM_FP would fire when included on targets like x86_64, but the
suggestion it gives in that case is totally bogus. Avoid giving bad
advice, by first checking whether we're being built for an appropriate
target, and only then do the soft-fp check.

rdar://155449666
This commit is contained in:
Jon Roelofs 2025-07-11 10:21:13 -07:00 committed by GitHub
parent df10df8b0c
commit a0fcb50bf9
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
clang/utils/TableGen/NeonEmitter.cpp
View File

@ -2417,7 +2417,11 @@ void NeonEmitter::run(raw_ostream &OS) {
OS << "#ifndef __ARM_NEON_H\n";
OS << "#define __ARM_NEON_H\n\n";
OS << "#ifndef __ARM_FP\n";
OS << "#if !defined(__arm__) && !defined(__aarch64__) && "
"!defined(__arm64ec__)\n";
OS << "#error \"<arm_neon.h> is intended only for ARM and AArch64 "
"targets\"\n";
OS << "#elif !defined(__ARM_FP)\n";
OS << "#error \"NEON intrinsics not available with the soft-float ABI. "
"Please use -mfloat-abi=softfp or -mfloat-abi=hard\"\n";
OS << "#else\n\n";