shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions 6 Packages Projects Releases Wiki Activity

Add DW_LNAME_HIP (#180999)

Browse Source 
In PR #89980, DW_LNAME_HIP was not added because of a value conflict
with DW_LNAME_Assembly. The value of DW_LNAME_HIP has been updated (see
https://dwarfstd.org/languages-v6.html). This commit adds DW_LNAME_HIP.
Tests added by that PR accommodates the new SourceLanguageName.
This commit is contained in:
accauble 2026-02-16 13:09:04 -05:00 committed by GitHub
parent 21bc4aa6a3
commit a33db04a63
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lldb/unittests/Target/LanguageTest.cpp
View File

@ -26,11 +26,7 @@ TEST_F(LanguageTest, SourceLanguage_GetDescription) {
auto lang_type = static_cast<lldb::LanguageType>(i);
SourceLanguage lang(lang_type);
// eLanguageTypeHIP is not implemented as a DW_LNAME because of a conflict.
if (lang_type == lldb::eLanguageTypeHIP)
EXPECT_FALSE(lang);
else
EXPECT_TRUE(lang);
EXPECT_TRUE(lang);
}
EXPECT_EQ(SourceLanguage(eLanguageTypeC_plus_plus).GetDescription(),

2
llvm/include/llvm/BinaryFormat/Dwarf.def
View File

@ -1072,7 +1072,6 @@ HANDLE_DW_LNAME(0x001a, Swift, "Swift", 0) // VVMM
HANDLE_DW_LNAME(0x001b, UPC, "Unified Parallel C (UPC)", 0)
HANDLE_DW_LNAME(0x001c, Zig, "Zig", 0)
HANDLE_DW_LNAME(0x001d, Assembly, "Assembly", 0)
// Conflict: HANDLE_DW_LNAME(0x001d, HIP, "HIP", 0)
HANDLE_DW_LNAME(0x001e, C_sharp, "C#", 0)
HANDLE_DW_LNAME(0x001f, Mojo, "Mojo", 0)
HANDLE_DW_LNAME(0x0020, GLSL, "OpenGL Shading Language", 0) // VVMMPP
@ -1084,6 +1083,7 @@ HANDLE_DW_LNAME(0x0025, SYCL, "SYCL", 0) // YYYYRR
HANDLE_DW_LNAME(0x0026, Ruby, "Ruby", 0) // VVMMPP
HANDLE_DW_LNAME(0x0027, Move, "Move", 0) // YYYYMM
HANDLE_DW_LNAME(0x0028, Hylo, "Hylo", 0)
HANDLE_DW_LNAME(0x0029, HIP, "HIP", 0)
HANDLE_DW_LNAME(0x002c, Metal, "Metal", 0) // VVMMPP
// DWARF attribute type encodings.

6
llvm/include/llvm/BinaryFormat/Dwarf.h
View File

@ -301,8 +301,8 @@ inline std::optional<SourceLanguage> toDW_LANG(SourceLanguageName name,
return DW_LANG_Go;
case DW_LNAME_Haskell:
return DW_LANG_Haskell;
// case DW_LNAME_HIP:
// return DW_LANG_HIP;
case DW_LNAME_HIP:
return DW_LANG_HIP;
case DW_LNAME_Java:
return DW_LANG_Java;
case DW_LNAME_Julia:
@ -430,7 +430,7 @@ toDW_LNAME(SourceLanguage language) {
case DW_LANG_Haskell:
return {{DW_LNAME_Haskell, 0}};
case DW_LANG_HIP:
return {}; // return {{DW_LNAME_HIP, 0}};
return {{DW_LNAME_HIP, 0}};
case DW_LANG_Java:
return {{DW_LNAME_Java, 0}};
case DW_LANG_Julia:

1
llvm/lib/BinaryFormat/Dwarf.cpp
View File

@ -550,6 +550,7 @@ StringRef llvm::dwarf::LanguageDescription(dwarf::SourceLanguageName Name,
case DW_LNAME_Dylan:
case DW_LNAME_Go:
case DW_LNAME_Haskell:
case DW_LNAME_HIP:
case DW_LNAME_HLSL:
case DW_LNAME_Java:
case DW_LNAME_Julia: