shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[LLD][COFF] Set isUsedInRegularObj for target symbols in resolveAlternateNames (#154837)

Browse Source 
Fixes: #154595

Prior to commit bbc8346e6bb543b0a87f52114fed7d766446bee1, this flag was
set by `insert()` from `addUndefined()`. Set it explicitly now.
This commit is contained in:
Jacek Caban 2025-08-22 04:05:19 -07:00 committed by GitHub
parent 2975e674ec
commit a6fcd1a663
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 26 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
lld/COFF/SymbolTable.cpp
View File

@ -1399,6 +1399,7 @@ void SymbolTable::resolveAlternateNames() {
auto toUndef = dyn_cast<Undefined>(toSym); auto toUndef = dyn_cast<Undefined>(toSym);
if (toUndef && (!toUndef->weakAlias || toUndef->isAntiDep)) if (toUndef && (!toUndef->weakAlias || toUndef->isAntiDep))
continue; continue;
toSym->isUsedInRegularObj = true;
if (toSym->isLazy()) if (toSym->isLazy())
forceLazy(toSym); forceLazy(toSym);
u->setWeakAlias(toSym); u->setWeakAlias(toSym);

25
lld/test/COFF/alternatename-lto.ll Normal file
View File

@ -0,0 +1,25 @@
; REQUIRES: x86
; RUN: mkdir -p %t.dir
; RUN: llvm-as -o %t.obj %s
; RUN: lld-link -out:%t.dll -dll -noentry %t.obj -export:test
target datalayout = "e-m:w-p270:32:32-p271:32:32-p272:64:64-i64:64-i128:128-f80:128-n8:16:32:64-S128"
target triple = "x86_64-unknown-windows-msvc19.33.0"
$alt = comdat any
@alt = weak_odr dso_local global i32 0, comdat, align 4
@ext = external dso_local global i32, align 4
; Function Attrs: noinline nounwind optnone uwtable
define dso_local i32 @test() #0 {
entry:
%0 = load i32, ptr @ext, align 4
ret i32 %0
}
attributes #0 = { noinline nounwind optnone uwtable }
!llvm.linker.options = !{!0}
!0 = !{!"/alternatename:ext=alt"}