shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[clang-tidy] remove misuse of getLocalOrGlobal for non common used options (#119948)

Browse Source 
[RFC](https://discourse.llvm.org/t/rfc-global-option-rules-for-clang-tidy/83647)
This commit is contained in:
Congcong Cai 2024-12-15 05:04:32 +08:00 committed by GitHub
parent 2564f1e199
commit aaadaee7b2
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
7 changed files with 9 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
clang-tools-extra/clang-tidy/bugprone/UncheckedOptionalAccessCheck.h
View File

@ -12,7 +12,6 @@
#include "../ClangTidyCheck.h" #include "../ClangTidyCheck.h"
#include "clang/ASTMatchers/ASTMatchFinder.h" #include "clang/ASTMatchers/ASTMatchFinder.h"
#include "clang/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.h" #include "clang/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.h"
#include <optional>
namespace clang::tidy::bugprone { namespace clang::tidy::bugprone {
@ -26,8 +25,7 @@ class UncheckedOptionalAccessCheck : public ClangTidyCheck {
public: public:
UncheckedOptionalAccessCheck(StringRef Name, ClangTidyContext *Context) UncheckedOptionalAccessCheck(StringRef Name, ClangTidyContext *Context)
: ClangTidyCheck(Name, Context), : ClangTidyCheck(Name, Context),
ModelOptions{ ModelOptions{Options.get("IgnoreSmartPointerDereference", false)} {}
Options.getLocalOrGlobal("IgnoreSmartPointerDereference", false)} {}
void registerMatchers(ast_matchers::MatchFinder *Finder) override; void registerMatchers(ast_matchers::MatchFinder *Finder) override;
void check(const ast_matchers::MatchFinder::MatchResult &Result) override; void check(const ast_matchers::MatchFinder::MatchResult &Result) override;
bool isLanguageVersionSupported(const LangOptions &LangOpts) const override { bool isLanguageVersionSupported(const LangOptions &LangOpts) const override {

2
clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp
View File

@ -277,7 +277,7 @@ ProTypeMemberInitCheck::ProTypeMemberInitCheck(StringRef Name,
ClangTidyContext *Context) ClangTidyContext *Context)
: ClangTidyCheck(Name, Context), : ClangTidyCheck(Name, Context),
IgnoreArrays(Options.get("IgnoreArrays", false)), IgnoreArrays(Options.get("IgnoreArrays", false)),
UseAssignment(Options.getLocalOrGlobal("UseAssignment", false)) {} UseAssignment(Options.get("UseAssignment", false)) {}
void ProTypeMemberInitCheck::registerMatchers(MatchFinder *Finder) { void ProTypeMemberInitCheck::registerMatchers(MatchFinder *Finder) {
auto IsUserProvidedNonDelegatingConstructor = auto IsUserProvidedNonDelegatingConstructor =

7
clang-tools-extra/clang-tidy/cppcoreguidelines/RvalueReferenceParamNotMovedCheck.cpp
View File

@ -119,11 +119,10 @@ void RvalueReferenceParamNotMovedCheck::check(
RvalueReferenceParamNotMovedCheck::RvalueReferenceParamNotMovedCheck( RvalueReferenceParamNotMovedCheck::RvalueReferenceParamNotMovedCheck(
StringRef Name, ClangTidyContext *Context) StringRef Name, ClangTidyContext *Context)
: ClangTidyCheck(Name, Context), : ClangTidyCheck(Name, Context),
AllowPartialMove(Options.getLocalOrGlobal("AllowPartialMove", false)), AllowPartialMove(Options.get("AllowPartialMove", false)),
IgnoreUnnamedParams( IgnoreUnnamedParams(Options.get("IgnoreUnnamedParams", false)),
Options.getLocalOrGlobal("IgnoreUnnamedParams", false)),
IgnoreNonDeducedTemplateTypes( IgnoreNonDeducedTemplateTypes(
Options.getLocalOrGlobal("IgnoreNonDeducedTemplateTypes", false)) {} Options.get("IgnoreNonDeducedTemplateTypes", false)) {}
void RvalueReferenceParamNotMovedCheck::storeOptions( void RvalueReferenceParamNotMovedCheck::storeOptions(
ClangTidyOptions::OptionMap &Opts) { ClangTidyOptions::OptionMap &Opts) {

2
clang-tools-extra/clang-tidy/performance/InefficientVectorOperationCheck.cpp
View File

@ -77,7 +77,7 @@ InefficientVectorOperationCheck::InefficientVectorOperationCheck(
: ClangTidyCheck(Name, Context), : ClangTidyCheck(Name, Context),
VectorLikeClasses(utils::options::parseStringList( VectorLikeClasses(utils::options::parseStringList(
Options.get("VectorLikeClasses", "::std::vector"))), Options.get("VectorLikeClasses", "::std::vector"))),
EnableProto(Options.getLocalOrGlobal("EnableProto", false)) {} EnableProto(Options.get("EnableProto", false)) {}
void InefficientVectorOperationCheck::storeOptions( void InefficientVectorOperationCheck::storeOptions(
ClangTidyOptions::OptionMap &Opts) { ClangTidyOptions::OptionMap &Opts) {

3
clang-tools-extra/clang-tidy/readability/RedundantAccessSpecifiersCheck.h
View File

@ -21,8 +21,7 @@ class RedundantAccessSpecifiersCheck : public ClangTidyCheck {
public: public:
RedundantAccessSpecifiersCheck(StringRef Name, ClangTidyContext *Context) RedundantAccessSpecifiersCheck(StringRef Name, ClangTidyContext *Context)
: ClangTidyCheck(Name, Context), : ClangTidyCheck(Name, Context),
CheckFirstDeclaration( CheckFirstDeclaration(Options.get("CheckFirstDeclaration", false)) {}
Options.getLocalOrGlobal("CheckFirstDeclaration", false)) {}
bool isLanguageVersionSupported(const LangOptions &LangOpts) const override { bool isLanguageVersionSupported(const LangOptions &LangOpts) const override {
return LangOpts.CPlusPlus; return LangOpts.CPlusPlus;
} }

2
clang-tools-extra/clang-tidy/readability/RedundantCastingCheck.cpp
View File

@ -94,7 +94,7 @@ RedundantCastingCheck::RedundantCastingCheck(StringRef Name,
ClangTidyContext *Context) ClangTidyContext *Context)
: ClangTidyCheck(Name, Context), : ClangTidyCheck(Name, Context),
IgnoreMacros(Options.getLocalOrGlobal("IgnoreMacros", true)), IgnoreMacros(Options.getLocalOrGlobal("IgnoreMacros", true)),
IgnoreTypeAliases(Options.getLocalOrGlobal("IgnoreTypeAliases", false)) {} IgnoreTypeAliases(Options.get("IgnoreTypeAliases", false)) {}
void RedundantCastingCheck::storeOptions(ClangTidyOptions::OptionMap &Opts) { void RedundantCastingCheck::storeOptions(ClangTidyOptions::OptionMap &Opts) {
Options.store(Opts, "IgnoreMacros", IgnoreMacros); Options.store(Opts, "IgnoreMacros", IgnoreMacros);

2
clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp
View File

@ -397,7 +397,7 @@ RenamerClangTidyCheck::RenamerClangTidyCheck(StringRef CheckName,
ClangTidyContext *Context) ClangTidyContext *Context)
: ClangTidyCheck(CheckName, Context), : ClangTidyCheck(CheckName, Context),
AggressiveDependentMemberLookup( AggressiveDependentMemberLookup(
Options.getLocalOrGlobal("AggressiveDependentMemberLookup", false)) {} Options.get("AggressiveDependentMemberLookup", false)) {}
RenamerClangTidyCheck::~RenamerClangTidyCheck() = default; RenamerClangTidyCheck::~RenamerClangTidyCheck() = default;
void RenamerClangTidyCheck::storeOptions(ClangTidyOptions::OptionMap &Opts) { void RenamerClangTidyCheck::storeOptions(ClangTidyOptions::OptionMap &Opts) {