shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions 6 Packages Projects Releases Wiki Activity

[Matrix] Assert that there's shapeinfo in Visit* (NFC). (#142416)

Browse Source 
We should only call Visit* for instructions with shape info. Turn early
exit into assert.

PR: https://github.com/llvm/llvm-project/pull/142416
This commit is contained in:
Florian Hahn 2025-06-02 18:18:42 +01:00 committed by GitHub
parent 705eedd47d
commit adba40e188
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 8 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp
View File

@ -2107,9 +2107,8 @@ public:
/// Lower load instructions, if shape information is available.
bool VisitLoad(LoadInst *Inst, Value *Ptr, IRBuilder<> &Builder) {
auto I = ShapeMap.find(Inst);
if (I == ShapeMap.end())
return false;
assert(I != ShapeMap.end() &&
"must only visit instructions with shape info");
LowerLoad(Inst, Ptr, Inst->getAlign(),
Builder.getInt64(I->second.getStride()), Inst->isVolatile(),
I->second);
@ -2119,9 +2118,8 @@ public:
bool VisitStore(StoreInst *Inst, Value *StoredVal, Value *Ptr,
IRBuilder<> &Builder) {
auto I = ShapeMap.find(StoredVal);
if (I == ShapeMap.end())
return false;
assert(I != ShapeMap.end() &&
"must only visit instructions with shape info");
LowerStore(Inst, StoredVal, Ptr, Inst->getAlign(),
Builder.getInt64(I->second.getStride()), Inst->isVolatile(),
I->second);
@ -2131,8 +2129,8 @@ public:
/// Lower binary operators, if shape information is available.
bool VisitBinaryOperator(BinaryOperator *Inst) {
auto I = ShapeMap.find(Inst);
if (I == ShapeMap.end())
return false;
assert(I != ShapeMap.end() &&
"must only visit instructions with shape info");
Value *Lhs = Inst->getOperand(0);
Value *Rhs = Inst->getOperand(1);
@ -2163,8 +2161,8 @@ public:
/// Lower unary operators, if shape information is available.
bool VisitUnaryOperator(UnaryOperator *Inst) {
auto I = ShapeMap.find(Inst);
if (I == ShapeMap.end())
return false;
assert(I != ShapeMap.end() &&
"must only visit instructions with shape info");
Value *Op = Inst->getOperand(0);