shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions 6 Packages Projects Releases Wiki Activity

[libc++][NFC] Disable std_format_spec benchmarks through lit instead of the preprocessor (#179228)

Browse Source 
This is probably a relic from when we didn't use lit to run benchmarks.
Nowadays we should just use the lit features to disable benchmarks like
we do in any other test instead of using the preprocessor.
This commit is contained in:
Nikolas Klauser 2026-02-03 13:19:42 +01:00 committed by GitHub
parent 9411f5db60
commit affcbce5ca
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 20 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
libcxx/test/benchmarks/format/std_format_spec_string_unicode.bench.cpp
View File

@ -6,17 +6,17 @@
// UNSUPPORTED: c++03, c++11, c++14, c++17
# include <concepts>
# include <format>
# include <string_view>
// UNSUPPORTED: libcpp-has-no-unicode
# include "benchmark/benchmark.h"
# include "make_string.h"
# include "test_macros.h"
#include <concepts>
#include <format>
#include <string_view>
# define SV(S) MAKE_STRING_VIEW(CharT, S)
#include "benchmark/benchmark.h"
#include "make_string.h"
#include "test_macros.h"
#if _LIBCPP_HAS_UNICODE
#define SV(S) MAKE_STRING_VIEW(CharT, S)
// generated with https://generator.lorem-ipsum.info/_latin
@ -285,16 +285,12 @@ BENCHMARK(BM_cyrillic_text<char>);
BENCHMARK(BM_japanese_text<char>);
BENCHMARK(BM_emoji_text<char>);
# ifndef TEST_HAS_NO_WIDE_CHARACTERS
#ifndef TEST_HAS_NO_WIDE_CHARACTERS
BENCHMARK(BM_ascii_text<wchar_t>);
BENCHMARK(BM_unicode_text<wchar_t>);
BENCHMARK(BM_cyrillic_text<wchar_t>);
BENCHMARK(BM_japanese_text<wchar_t>);
BENCHMARK(BM_emoji_text<wchar_t>);
# endif
#endif
BENCHMARK_MAIN();
#else
int main(int, char**) { return 0; }
#endif

25
libcxx/test/benchmarks/format/std_format_spec_string_unicode_escape.bench.cpp
View File

@ -8,21 +8,20 @@
// UNSUPPORTED: c++03, c++11, c++14, c++17, c++20
// UNSUPPORTED: libcpp-has-no-unicode
// This test formats a larger piece of text in "escaped" mode. It uses several
// datasets to give an impression how the amount of multibyte UTF-8 sequences
// and larger grapheme clusters affect the performance.
# include <concepts>
# include <format>
# include <string_view>
#include <concepts>
#include <format>
#include <string_view>
# include "benchmark/benchmark.h"
# include "make_string.h"
# include "test_macros.h"
#include "benchmark/benchmark.h"
#include "make_string.h"
#if _LIBCPP_HAS_UNICODE
# define SV(S) MAKE_STRING_VIEW(CharT, S)
#define SV(S) MAKE_STRING_VIEW(CharT, S)
// generated with https://generator.lorem-ipsum.info/_latin
@ -288,16 +287,12 @@ BENCHMARK(BM_cyrillic_escaped<char>);
BENCHMARK(BM_japanese_escaped<char>);
BENCHMARK(BM_emoji_escaped<char>);
# ifndef TEST_HAS_NO_WIDE_CHARACTERS
#ifndef TEST_HAS_NO_WIDE_CHARACTERS
BENCHMARK(BM_ascii_escaped<wchar_t>);
BENCHMARK(BM_unicode_escaped<wchar_t>);
BENCHMARK(BM_cyrillic_escaped<wchar_t>);
BENCHMARK(BM_japanese_escaped<wchar_t>);
BENCHMARK(BM_emoji_escaped<wchar_t>);
# endif
#endif
BENCHMARK_MAIN();
#else
int main(int, char**) { return 0; }
#endif