From b149fc7755b1ddf95060df1b87a3b0a9890a4e40 Mon Sep 17 00:00:00 2001 From: Jungwook Park Date: Fri, 22 Aug 2025 13:11:27 +0100 Subject: [PATCH] [mlir][scf] Quick fix to scf.execute_region no_inline (#154931) Asm printer should exclude `no_inline` attr during printing optional attrs at the bottom. --- mlir/lib/Dialect/SCF/IR/SCF.cpp | 3 +-- mlir/test/Dialect/SCF/canonicalize.mlir | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/mlir/lib/Dialect/SCF/IR/SCF.cpp b/mlir/lib/Dialect/SCF/IR/SCF.cpp index 0dbc041d231a..84f9777a443f 100644 --- a/mlir/lib/Dialect/SCF/IR/SCF.cpp +++ b/mlir/lib/Dialect/SCF/IR/SCF.cpp @@ -157,8 +157,7 @@ void ExecuteRegionOp::print(OpAsmPrinter &p) { p.printRegion(getRegion(), /*printEntryBlockArgs=*/false, /*printBlockTerminators=*/true); - - p.printOptionalAttrDict((*this)->getAttrs()); + p.printOptionalAttrDict((*this)->getAttrs(), /*elidedAttrs=*/{"no_inline"}); } LogicalResult ExecuteRegionOp::verify() { diff --git a/mlir/test/Dialect/SCF/canonicalize.mlir b/mlir/test/Dialect/SCF/canonicalize.mlir index 7804cc7026d6..2752c492cb2b 100644 --- a/mlir/test/Dialect/SCF/canonicalize.mlir +++ b/mlir/test/Dialect/SCF/canonicalize.mlir @@ -1479,7 +1479,7 @@ func.func @execute_region_no_inline() { // CHECK-NEXT: scf.execute_region // CHECK-NEXT: %[[VAL:.*]] = "test.val"() : () -> i64 // CHECK-NEXT: scf.yield %[[VAL]] : i64 -// CHECK-NEXT: } +// CHECK-NOT: no_inline // -----