shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions 6 Packages Projects Releases Wiki Activity

[CodeGen] Ignore ANNOTATION_LABEL in scheduler (#190499)

Browse Source 
This fixes a crash in `clang` for `armv7` targets when optimizations are
enabled.

Fixes #190497
This commit is contained in:
Trung Nguyen 2026-04-06 22:16:01 +10:00 committed by GitHub
parent 0403639667
commit b6e7c475cb
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 40 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
llvm/lib/CodeGen/SelectionDAG/ScheduleDAGRRList.cpp
View File

@ -712,6 +712,7 @@ void ScheduleDAGRRList::EmitNode(SUnit *SU) {
case ISD::CopyToReg:
case ISD::CopyFromReg:
case ISD::EH_LABEL:
case ISD::ANNOTATION_LABEL:
// Noops don't affect the scoreboard state. Copies are likely to be
// removed.
return;

39
llvm/test/CodeGen/ARM/pr190497.ll Normal file
View File

@ -0,0 +1,39 @@
; RUN: llc -mtriple=thumbv7-windows-msvc -O1 < %s | FileCheck %s
; We used to crash on ARM with optimizations on.
; C source:
; void foo(void) {
; __annotation(L"annotation");
; }
define void @foo() !dbg !8 {
entry:
; CHECK-LABEL: foo:
; CHECK: {{.*}}annotation0:
; CHECK: bx lr
call void @llvm.codeview.annotation(metadata !12), !dbg !13
ret void, !dbg !14
}
declare void @llvm.codeview.annotation(metadata)
!llvm.dbg.cu = !{!0}
!llvm.module.flags = !{!2, !3}
!0 = distinct !DICompileUnit(language: DW_LANG_C11, file: !1, emissionKind: FullDebug)
!1 = !DIFile(filename: "pr190497.c", directory: ".")
!2 = !{i32 2, !"CodeView", i32 1}
!3 = !{i32 2, !"Debug Info Version", i32 3}
!8 = distinct !DISubprogram(name: "foo", scope: !1, file: !1, line: 1, type: !9, unit: !0)
!9 = !DISubroutineType(types: !10)
!10 = !{null}
!12 = !{!"annotation"}
!13 = !DILocation(line: 2, scope: !8)
!14 = !DILocation(line: 3, scope: !8)
; CHECK: .short 4121 @ Record kind: S_ANNOTATION
; CHECK-NEXT: .secrel32 {{.*}}annotation0
; CHECK-NEXT: .secidx {{.*}}annotation0
; CHECK-NEXT: .short 1
; CHECK-NEXT: .asciz "annotation"