From b6e8fe3dacb49dfe4c67dbc3cc40d59cd902f519 Mon Sep 17 00:00:00 2001 From: Philip Reames Date: Tue, 17 Nov 2015 00:15:09 +0000 Subject: [PATCH] [PRE] Preserve !invariant.load metadata Spoted via inspection. Test case included. llvm-svn: 253275 --- llvm/lib/Transforms/Scalar/GVN.cpp | 2 ++ llvm/test/Transforms/GVN/invariant-load.ll | 17 +++++++++++++++++ 2 files changed, 19 insertions(+) diff --git a/llvm/lib/Transforms/Scalar/GVN.cpp b/llvm/lib/Transforms/Scalar/GVN.cpp index e2822e320a85..06faa2d76b61 100644 --- a/llvm/lib/Transforms/Scalar/GVN.cpp +++ b/llvm/lib/Transforms/Scalar/GVN.cpp @@ -1669,6 +1669,8 @@ bool GVN::PerformLoadPRE(LoadInst *LI, AvailValInBlkVect &ValuesPerBlock, if (Tags) NewLoad->setAAMetadata(Tags); + if (auto *MD = LI->getMetadata(LLVMContext::MD_invariant_load)) + NewLoad->setMetadata(LLVMContext::MD_invariant_load, MD); if (auto *InvGroupMD = LI->getMetadata(LLVMContext::MD_invariant_group)) NewLoad->setMetadata(LLVMContext::MD_invariant_group, InvGroupMD); diff --git a/llvm/test/Transforms/GVN/invariant-load.ll b/llvm/test/Transforms/GVN/invariant-load.ll index 982da8cfe486..f74fd3392c18 100644 --- a/llvm/test/Transforms/GVN/invariant-load.ll +++ b/llvm/test/Transforms/GVN/invariant-load.ll @@ -114,6 +114,23 @@ entry: ret i32 %res } +define i32 @test8(i1 %cnd, i32* %p) { +; CHECK-LABEL: test8 +; CHECK: @bar +; CHECK: load i32, i32* %p2, !invariant.load +; CHECK: br label %merge +entry: + %v1 = load i32, i32* %p, !invariant.load !0 + br i1 %cnd, label %taken, label %merge +taken: + %p2 = call i32* (...) @bar(i32* %p) + br label %merge +merge: + %p3 = phi i32* [%p, %entry], [%p2, %taken] + %v2 = load i32, i32* %p3, !invariant.load !0 + %res = sub i32 %v1, %v2 + ret i32 %res +} !0 = !{ }