shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[ValueTracking] Support scalable vector splats of ConstantInt/ConstantFP in isGuaranteedNotToBeUndefOrPoison. (#142894)

Browse Source 
Scalable vectors use insertelt+shufflevector ConstantExpr to
represent a splat.
This commit is contained in:
Craig Topper 2025-06-05 22:08:03 -07:00 committed by GitHub
parent 7005a76638
commit b8a4a3b99c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 43 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
llvm/lib/Analysis/ValueTracking.cpp
View File

@ -7580,16 +7580,23 @@ static bool isGuaranteedNotToBeUndefOrPoison(
if (isa<UndefValue>(C))
return !includesUndef(Kind);
if (isa<ConstantInt>(C) || isa<GlobalVariable>(C) || isa<ConstantFP>(V) ||
if (isa<ConstantInt>(C) || isa<GlobalVariable>(C) || isa<ConstantFP>(C) ||
isa<ConstantPointerNull>(C) || isa<Function>(C))
return true;
if (C->getType()->isVectorTy() && !isa<ConstantExpr>(C)) {
if (includesUndef(Kind) && C->containsUndefElement())
return false;
if (includesPoison(Kind) && C->containsPoisonElement())
return false;
return !C->containsConstantExpression();
if (C->getType()->isVectorTy()) {
if (isa<ConstantExpr>(C)) {
// Scalable vectors can use a ConstantExpr to build a splat.
if (Constant *SplatC = C->getSplatValue())
if (isa<ConstantInt>(SplatC) || isa<ConstantFP>(SplatC))
return true;
} else {
if (includesUndef(Kind) && C->containsUndefElement())
return false;
if (includesPoison(Kind) && C->containsPoisonElement())
return false;
return !C->containsConstantExpression();
}
}
}

2
llvm/test/Transforms/Attributor/nofpclass.ll
View File

@ -2665,7 +2665,7 @@ define [4 x float] @constant_aggregate_zero() {
define <vscale x 4 x float> @scalable_splat_pnorm() {
; CHECK: Function Attrs: mustprogress nofree norecurse nosync nounwind willreturn memory(none)
; CHECK-LABEL: define <vscale x 4 x float> @scalable_splat_pnorm
; CHECK-LABEL: define noundef <vscale x 4 x float> @scalable_splat_pnorm
; CHECK-SAME: () #[[ATTR3]] {
; CHECK-NEXT: ret <vscale x 4 x float> splat (float 1.000000e+00)
;

28
llvm/test/Transforms/InstCombine/select-and-or.ll
View File

@ -104,6 +104,20 @@ define i1 @logical_or_implies(i32 %x) {
ret i1 %res
}
; Safe to convert to or due to poison implication.
define <vscale x 2 x i1> @logical_or_implies_scalablevec(<vscale x 2 x i32> %x) {
; CHECK-LABEL: @logical_or_implies_scalablevec(
; CHECK-NEXT: [[C1:%.*]] = icmp eq <vscale x 2 x i32> [[X:%.*]], zeroinitializer
; CHECK-NEXT: [[C2:%.*]] = icmp eq <vscale x 2 x i32> [[X]], splat (i32 42)
; CHECK-NEXT: [[RES:%.*]] = or <vscale x 2 x i1> [[C1]], [[C2]]
; CHECK-NEXT: ret <vscale x 2 x i1> [[RES]]
;
%c1 = icmp eq <vscale x 2 x i32> %x, zeroinitializer
%c2 = icmp eq <vscale x 2 x i32> %x, splat (i32 42)
%res = select <vscale x 2 x i1> %c1, <vscale x 2 x i1> splat (i1 true), <vscale x 2 x i1> %c2
ret <vscale x 2 x i1> %res
}
; Will fold after conversion to or.
define i1 @logical_or_implies_folds(i32 %x) {
; CHECK-LABEL: @logical_or_implies_folds(
@ -129,6 +143,20 @@ define i1 @logical_and_implies(i32 %x) {
ret i1 %res
}
; Safe to convert to and due to poison implication.
define <vscale x 2 x i1> @logical_and_implies_scalablevec(<vscale x 2 x i32> %x) {
; CHECK-LABEL: @logical_and_implies_scalablevec(
; CHECK-NEXT: [[C1:%.*]] = icmp ne <vscale x 2 x i32> [[X:%.*]], zeroinitializer
; CHECK-NEXT: [[C2:%.*]] = icmp ne <vscale x 2 x i32> [[X]], splat (i32 42)
; CHECK-NEXT: [[RES:%.*]] = and <vscale x 2 x i1> [[C1]], [[C2]]
; CHECK-NEXT: ret <vscale x 2 x i1> [[RES]]
;
%c1 = icmp ne <vscale x 2 x i32> %x, zeroinitializer
%c2 = icmp ne <vscale x 2 x i32> %x, splat (i32 42)
%res = select <vscale x 2 x i1> %c1, <vscale x 2 x i1> %c2, <vscale x 2 x i1> zeroinitializer
ret <vscale x 2 x i1> %res
}
; Will fold after conversion to and.
define i1 @logical_and_implies_folds(i32 %x) {
; CHECK-LABEL: @logical_and_implies_folds(