shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[SelectionDAG] improve error message for invalid op bundles (#148722)

Browse Source
This commit is contained in:
Florian Mayer 2025-07-14 20:41:10 -07:00 committed by GitHub
parent d2bcc51a5a
commit be200e2b80
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 24 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
View File

@ -3351,13 +3351,30 @@ void SelectionDAGBuilder::visitInvoke(const InvokeInst &I) {
// Deopt and ptrauth bundles are lowered in helper functions, and we don't
// have to do anything here to lower funclet bundles.
if (I.hasOperandBundlesOtherThan(
{LLVMContext::OB_deopt, LLVMContext::OB_gc_transition,
LLVMContext::OB_gc_live, LLVMContext::OB_funclet,
LLVMContext::OB_cfguardtarget, LLVMContext::OB_ptrauth,
LLVMContext::OB_clang_arc_attachedcall, LLVMContext::OB_kcfi}))
constexpr uint32_t kAllowedBundles[] = {
LLVMContext::OB_deopt,
LLVMContext::OB_gc_transition,
LLVMContext::OB_gc_live,
LLVMContext::OB_funclet,
LLVMContext::OB_cfguardtarget,
LLVMContext::OB_ptrauth,
LLVMContext::OB_clang_arc_attachedcall,
LLVMContext::OB_kcfi};
if (I.hasOperandBundlesOtherThan(kAllowedBundles)) {
std::string Error;
for (unsigned i = 0, e = I.getNumOperandBundles(); i != e; ++i) {
OperandBundleUse U = I.getOperandBundleAt(i);
bool First = true;
if (is_contained(kAllowedBundles, U.getTagID()))
continue;
if (!First)
Error += ", ";
First = false;
Error += U.getTagName();
}
reportFatalUsageError(
"cannot lower invokes with arbitrary operand bundles!");
Twine("cannot lower invokes with arbitrary operand bundles: ", Error));
}
const Value *Callee(I.getCalledOperand());
const Function *Fn = dyn_cast<Function>(Callee);

2
llvm/test/CodeGen/X86/invalid-operand-bundle-invoke.ll
View File

@ -1,6 +1,6 @@
; RUN: not llc -mtriple=x86_64-unknown-linux-gnu < %s 2>&1 | FileCheck %s
; CHECK: LLVM ERROR: cannot lower invokes with arbitrary operand bundles!
; CHECK: LLVM ERROR: cannot lower invokes with arbitrary operand bundles: foo
declare void @g()
declare i32 @__gxx_personality_v0(...)