shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions 6 Packages Projects Releases Wiki Activity

[mlir][spirv] Change Spirv.GlobalVariableOp builtin -> built_in (#152148)

Browse Source 
GlobalVariableOp describes that built_in specifies SPIR-V BuiltIn
decoration associated with the op. The attribute was defined as builtin
in the tablegen (no uderscore). This was causing correct
GlobalVariableOp decorations like: built_in("GlobalInvocationId") to be
saved as a new attribute making it impossible to access the built_in
attribute through getBuiltinAttr.
This commit is contained in:
moscickimilosz 2025-08-05 20:47:37 +01:00 committed by GitHub
parent f8a4f61101
commit c1add93e45
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
mlir/include/mlir/Dialect/SPIRV/IR/SPIRVStructureOps.td
View File

@ -451,7 +451,7 @@ def SPIRV_GlobalVariableOp : SPIRV_Op<"GlobalVariable", [InModuleScope, Symbol]>
OptionalAttr<I32Attr>:$location,
OptionalAttr<I32Attr>:$binding,
OptionalAttr<I32Attr>:$descriptor_set,
OptionalAttr<StrAttr>:$builtin,
OptionalAttr<StrAttr>:$built_in,
OptionalAttr<SPIRV_LinkageAttributesAttr>:$linkage_attributes
);