shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[PS5][Driver] Fix bad negative check in ps5-linker.c test case (#147484)

Browse Source 
A regex used in a negative check had an unintended match with the
pseudo-random part of the temporary directory created by a lit run on
the SIE buildbot, causing a spurious test failure:

https://lab.llvm.org/buildbot/#/builders/144/builds/29507

    // CHECK-NO-CRT-NOT: crt{{[^"]*}}.o"
                         ^
    <stdin>:7:224: note: found here
    [...] "/tmp/lit-tmp-vcrtn3vi/ps5-linker-ee5f76.o" "-r"
                         !~~~~~~~~~~~~~~~~~~~~~~~~~~~

The updated check avoids such accidental matches.
This commit is contained in:
Edd Dawson 2025-07-08 11:06:36 +01:00 committed by GitHub
parent db7888ca9a
commit c6776bbe19
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
clang/test/Driver/ps5-linker.c
View File

@ -165,7 +165,7 @@
// CHECK-SHARED-CRT-SAME: "-l:crtendS.o" "-l:crtn.o"
// CHECK-STATIC-CRT-SAME: "-l:crtend.o" "-l:crtn.o"
// CHECK-NO-CRT-NOT: crt{{[^"]*}}.o"
// CHECK-NO-CRT-NOT: "-l:crt
// CHECK-NO-LIBS-NOT: "-l{{[^"]*}}"
// Test the driver's control over the -fcrash-diagnostics-dir behavior with linker flags.