shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[llvm][utils] Avoid 'raw_string_ostream::str()' (NFC) (#97160)

Browse Source 
Since `raw_string_ostream` doesn't own the string buffer, it is
desirable (in terms of memory safety) for users to directly reference
the string buffer rather than use `raw_string_ostream::str()`.

Work towards TODO comment to remove `raw_string_ostream::str()`.
This commit is contained in:
Youngsuk Kim 2024-06-29 18:50:52 -04:00 committed by GitHub
parent 56ef6a2eb2
commit caf26b9437
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
llvm/utils/FileCheck/FileCheck.cpp
View File

@ -641,7 +641,7 @@ static void DumpAnnotatedInput(raw_ostream &OS, const FileCheckRequest &Req,
LineOS = &ElidedLinesOS; LineOS = &ElidedLinesOS;
else { else {
LineOS = &OS; LineOS = &OS;
DumpEllipsisOrElidedLines(OS, ElidedLinesOS.str(), LabelWidth); DumpEllipsisOrElidedLines(OS, ElidedLines, LabelWidth);
} }
// Print right-aligned line number. // Print right-aligned line number.
@ -723,7 +723,7 @@ static void DumpAnnotatedInput(raw_ostream &OS, const FileCheckRequest &Req,
++AnnotationItr; ++AnnotationItr;
} }
} }
DumpEllipsisOrElidedLines(OS, ElidedLinesOS.str(), LabelWidth); DumpEllipsisOrElidedLines(OS, ElidedLines, LabelWidth);
OS << ">>>>>>\n"; OS << ">>>>>>\n";
} }

4
llvm/utils/TableGen/AsmMatcherEmitter.cpp
View File

@ -2367,10 +2367,10 @@ emitConvertFuncs(CodeGenTarget &Target, StringRef ClassName,
OS << "};\n\n"; OS << "};\n\n";
// Spit out the conversion driver function. // Spit out the conversion driver function.
OS << CvtOS.str(); OS << ConvertFnBody;
// Spit out the operand number lookup function. // Spit out the operand number lookup function.
OS << OpOS.str(); OS << OperandFnBody;
return ConversionTable.size(); return ConversionTable.size();
} }

12
llvm/utils/TableGen/AsmWriterEmitter.cpp
View File

@ -1162,8 +1162,8 @@ void AsmWriterEmitter::EmitPrintAliasInstruction(raw_ostream &O) {
PatternCount - PatternStart); PatternCount - PatternStart);
} }
if (OpcodeO.str().empty()) { if (PatternsForOpcode.empty()) {
O << HeaderO.str(); O << Header;
O << " return false;\n"; O << " return false;\n";
O << "}\n\n"; O << "}\n\n";
O << "#endif // PRINT_ALIAS_INSTR\n"; O << "#endif // PRINT_ALIAS_INSTR\n";
@ -1177,15 +1177,15 @@ void AsmWriterEmitter::EmitPrintAliasInstruction(raw_ostream &O) {
<< " const MCSubtargetInfo &STI,\n" << " const MCSubtargetInfo &STI,\n"
<< " unsigned PredicateIndex);\n"; << " unsigned PredicateIndex);\n";
O << HeaderO.str(); O << Header;
O.indent(2) << "static const PatternsForOpcode OpToPatterns[] = {\n"; O.indent(2) << "static const PatternsForOpcode OpToPatterns[] = {\n";
O << OpcodeO.str(); O << PatternsForOpcode;
O.indent(2) << "};\n\n"; O.indent(2) << "};\n\n";
O.indent(2) << "static const AliasPattern Patterns[] = {\n"; O.indent(2) << "static const AliasPattern Patterns[] = {\n";
O << PatternO.str(); O << Patterns;
O.indent(2) << "};\n\n"; O.indent(2) << "};\n\n";
O.indent(2) << "static const AliasPatternCond Conds[] = {\n"; O.indent(2) << "static const AliasPatternCond Conds[] = {\n";
O << CondO.str(); O << Conds;
O.indent(2) << "};\n\n"; O.indent(2) << "};\n\n";
O.indent(2) << "static const char AsmStrings[] =\n"; O.indent(2) << "static const char AsmStrings[] =\n";
for (const auto &P : AsmStrings) { for (const auto &P : AsmStrings) {

2
llvm/utils/TableGen/Common/VarLenCodeEmitterGen.cpp
View File

@ -405,7 +405,7 @@ void VarLenCodeEmitterGen::emitInstructionBaseValues(
IS.indent(4) << "{/*NumBits*/0, /*Index*/0}\n };\n"; IS.indent(4) << "{/*NumBits*/0, /*Index*/0}\n };\n";
SS.indent(4) << "UINT64_C(0)\n };\n"; SS.indent(4) << "UINT64_C(0)\n };\n";
OS << IS.str() << SS.str(); OS << IndexArray << StorageArray;
} }
std::string VarLenCodeEmitterGen::getInstructionCases(Record *R, std::string VarLenCodeEmitterGen::getInstructionCases(Record *R,