From cbb287c2ecbde244db67cedb817933628a991f55 Mon Sep 17 00:00:00 2001 From: Erich Keane Date: Tue, 17 Oct 2017 17:45:21 +0000 Subject: [PATCH] Replace use of SmallVector::back + pop_back with pop_back_val I ran across an instance where the value was being loaded out via back, then immediately popped. Since pop_back_val is more efficient at this (it moves out), replace this instance. llvm-svn: 316015 --- clang/lib/Sema/AnalysisBasedWarnings.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/clang/lib/Sema/AnalysisBasedWarnings.cpp b/clang/lib/Sema/AnalysisBasedWarnings.cpp index 08fc0802c6e7..bdfed6ead107 100644 --- a/clang/lib/Sema/AnalysisBasedWarnings.cpp +++ b/clang/lib/Sema/AnalysisBasedWarnings.cpp @@ -361,8 +361,7 @@ static bool hasThrowOutNonThrowingFunc(SourceLocation &OpLoc, CFG *BodyCFG) { SmallVector Stack; Stack.push_back(&BodyCFG->getEntry()); while (!Stack.empty()) { - CFGBlock *CurBlock = Stack.back(); - Stack.pop_back(); + CFGBlock *CurBlock = Stack.pop_back_val(); unsigned ID = CurBlock->getBlockID(); ThrowState CurState = States[ID];