[libc][math] Refactor frexpf implementation to header-only in src/__support/math folder. (#147893)

Part of #147386

in preparation for:
https://discourse.llvm.org/t/rfc-make-clang-builtin-math-functions-constexpr-with-llvm-libc-to-support-c-23-constexpr-math-functions/86450
This commit is contained in:
Muhammad Bassiouni 2025-07-12 18:08:58 +03:00 committed by GitHub
parent 67db34863c
commit d06e9ce1dd
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
7 changed files with 79 additions and 6 deletions

View File

@ -13,6 +13,7 @@
#include "math/expf.h"
#include "math/expf16.h"
#include "math/frexpf.h"
#include "math/frexpf128.h"
#include "math/frexpf16.h"

24
libc/shared/math/frexpf.h Normal file
View File

@ -0,0 +1,24 @@
//===-- Shared frexpf function ------------------------------------*- C++
//-*-===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#ifndef LLVM_LIBC_SHARED_MATH_FREXPF_H
#define LLVM_LIBC_SHARED_MATH_FREXPF_H
#include "shared/libc_common.h"
#include "src/__support/math/frexpf.h"
namespace LIBC_NAMESPACE_DECL {
namespace shared {
using math::frexpf;
} // namespace shared
} // namespace LIBC_NAMESPACE_DECL
#endif // LLVM_LIBC_SHARED_MATH_FREXPF_H

View File

@ -74,3 +74,11 @@ add_header_library(
libc.src.__support.macros.properties.types
libc.src.__support.FPUtil.manipulation_functions
)
add_header_library(
frexpf
HDRS
frexpf.h
DEPENDS
libc.src.__support.FPUtil.manipulation_functions
)

View File

@ -0,0 +1,28 @@
//===-- Implementation header for frexpf ------------------------*- C++ -*-===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#ifndef LLVM_LIBC_SRC___SUPPORT_MATH_FREXPF_H
#define LLVM_LIBC_SRC___SUPPORT_MATH_FREXPF_H
#include "src/__support/FPUtil/ManipulationFunctions.h"
#include "src/__support/common.h"
#include "src/__support/macros/config.h"
namespace LIBC_NAMESPACE_DECL {
namespace math {
static constexpr float frexpf(float x, int *exp) {
return fputil::frexp(x, *exp);
}
} // namespace math
} // namespace LIBC_NAMESPACE_DECL
#endif // LLVM_LIBC_SRC___SUPPORT_MATH_FREXPF_H

View File

@ -1759,7 +1759,7 @@ add_entrypoint_object(
HDRS
../frexpf.h
DEPENDS
libc.src.__support.FPUtil.manipulation_functions
libc.src.__support.math.frexpf
)
add_entrypoint_object(

View File

@ -7,14 +7,13 @@
//===----------------------------------------------------------------------===//
#include "src/math/frexpf.h"
#include "src/__support/FPUtil/ManipulationFunctions.h"
#include "src/__support/common.h"
#include "src/__support/macros/config.h"
#include "src/__support/math/frexpf.h"
namespace LIBC_NAMESPACE_DECL {
LLVM_LIBC_FUNCTION(float, frexpf, (float x, int *exp)) {
return fputil::frexp(x, *exp);
return math::frexpf(x, exp);
}
} // namespace LIBC_NAMESPACE_DECL

View File

@ -2169,6 +2169,14 @@ libc_support_library(
],
)
libc_support_library(
name = "__support_math_frexpf",
hdrs = ["src/__support/math/frexpf.h"],
deps = [
":__support_fputil_manipulation_functions",
],
)
############################### complex targets ################################
libc_function(
@ -3216,7 +3224,12 @@ libc_math_function(name = "fmulf128")
libc_math_function(name = "frexp")
libc_math_function(name = "frexpf")
libc_math_function(
name = "frexpf",
additional_deps = [
":__support_math_frexpf",
],
)
libc_math_function(name = "frexpl")