shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions 6 Packages Projects Releases Wiki Activity

[flang][OpenMP] Rename GetAllDesignators to GetTopLevelDesignators, NFC (#188520)

Browse Source 
The function collects all top-level designators. Emphasize the "top
level" part for clarity.
This commit is contained in:
Krzysztof Parzyszek 2026-03-25 11:12:24 -05:00 committed by GitHub
parent 32720fba18
commit d893374b85
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
flang/include/flang/Semantics/openmp-utils.h
View File

@ -105,7 +105,7 @@ std::optional<bool> GetLogicalValue(const SomeExpr &expr);
std::optional<bool> IsContiguous(
SemanticsContext &semaCtx, const parser::OmpObject &object);
std::vector<SomeExpr> GetAllDesignators(const SomeExpr &expr);
std::vector<SomeExpr> GetTopLevelDesignators(const SomeExpr &expr);
const SomeExpr *HasStorageOverlap(
const SomeExpr &base, llvm::ArrayRef<SomeExpr> exprs);
bool IsAssignment(const parser::ActionStmt *x);

2
flang/lib/Semantics/check-omp-atomic.cpp
View File

@ -586,7 +586,7 @@ void OmpStructureChecker::CheckAtomicVariable(
atom.AsFortran());
}
std::vector<SomeExpr> dsgs{GetAllDesignators(atom)};
std::vector<SomeExpr> dsgs{GetTopLevelDesignators(atom)};
// Procedure references are valid if they return a pointer to a scalar.
// Just return if we don't have exactly one designator - other checks will

6
flang/lib/Semantics/openmp-utils.cpp
View File

@ -418,7 +418,7 @@ struct DesignatorCollector : public evaluate::Traverse<DesignatorCollector,
}
};
std::vector<SomeExpr> GetAllDesignators(const SomeExpr &expr) {
std::vector<SomeExpr> GetTopLevelDesignators(const SomeExpr &expr) {
return DesignatorCollector{}(expr);
}
@ -480,7 +480,7 @@ static bool HasCommonTopLevelDesignators(
// Compare designators directly as expressions. This will ensure
// that x(y) and x(y+1) are not flagged as overlapping, whereas
// the symbol vectors for both of these would be identical.
std::vector<SomeExpr> otherDsgs{GetAllDesignators(other)};
std::vector<SomeExpr> otherDsgs{GetTopLevelDesignators(other)};
for (auto &s : baseDsgs) {
if (llvm::any_of(otherDsgs, [&](auto &&t) { return s == t; })) {
@ -493,7 +493,7 @@ static bool HasCommonTopLevelDesignators(
const SomeExpr *HasStorageOverlap(
const SomeExpr &base, llvm::ArrayRef<SomeExpr> exprs) {
evaluate::SymbolVector baseSyms{evaluate::GetSymbolVector(base)};
std::vector<SomeExpr> baseDsgs{GetAllDesignators(base)};
std::vector<SomeExpr> baseDsgs{GetTopLevelDesignators(base)};
for (const SomeExpr &expr : exprs) {
if (!HasCommonDesignatorSymbols(baseSyms, expr)) {