shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions 6 Packages Projects Releases Wiki Activity

[libclc] [cmake] Fix per-target *_convert.cl dependencies (#127315)

Browse Source 
Fix `add_libclc_builtin_set` to add an appropriate dependency to either
`clspv-generate_convert.cl` or `generate_convert.cl` based on the `ARCH`
argument, rather than to both unconditionally. This fixes build failures
due to missing dependencies when `clspv*` targets are not enabled.

The added check mirrors the one from `libclc/CMakeLists.txt`.

Fixes: #127378
This commit is contained in:
Michał Górny 2025-02-16 08:48:52 +01:00 committed by GitHub
parent c6d95c441a
commit dbc98cfa46
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
libclc/cmake/modules/AddLibclc.cmake
View File

@ -249,13 +249,19 @@ function(add_libclc_builtin_set)
get_filename_component( file_dir ${file} DIRECTORY )
if( ARG_ARCH STREQUAL spirv OR ARG_ARCH STREQUAL spirv64 )
set(CONVERT_DEP clspv-generate_convert.cl)
else()
set(CONVERT_DEP generate_convert.cl)
endif()
compile_to_bc(
TRIPLE ${ARG_TRIPLE}
INPUT ${input_file}
OUTPUT ${output_file}
EXTRA_OPTS -fno-builtin -nostdlib
"${ARG_COMPILE_FLAGS}" -I${CMAKE_CURRENT_SOURCE_DIR}/${file_dir}
DEPENDENCIES generate_convert.cl clspv-generate_convert.cl
DEPENDENCIES ${CONVERT_DEP}
)
list( APPEND bytecode_files ${output_file} )
endforeach()