shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[NFC][Cloning] Simplify the flow in FindDebugInfoToIdentityMap (#129144)

Browse Source 
Summary:
The new flow should make it more clear what is happening in cases of
Different of Cloned modules.

Test Plan:
ninja check-llvm-unit check-llvm
This commit is contained in:
Artem Pianykh 2025-03-09 17:49:24 +00:00 committed by GitHub
parent a7d5b3f711
commit df570dadcb
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 17 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
llvm/lib/Transforms/Utils/CloneFunction.cpp
View File

@ -160,32 +160,32 @@ MetadataSetTy
llvm::FindDebugInfoToIdentityMap(CloneFunctionChangeType Changes, llvm::FindDebugInfoToIdentityMap(CloneFunctionChangeType Changes,
DebugInfoFinder &DIFinder, DebugInfoFinder &DIFinder,
DISubprogram *SPClonedWithinModule) { DISubprogram *SPClonedWithinModule) {
if (Changes >= CloneFunctionChangeType::DifferentModule)
return {};
if (DIFinder.subprogram_count() == 0)
assert(!SPClonedWithinModule &&
"Subprogram should be in DIFinder->subprogram_count()...");
MetadataSetTy MD; MetadataSetTy MD;
if (Changes < CloneFunctionChangeType::DifferentModule && // Avoid cloning types, compile units, and (other) subprograms.
DIFinder.subprogram_count() > 0) { for (DISubprogram *ISP : DIFinder.subprograms())
// Avoid cloning types, compile units, and (other) subprograms. if (ISP != SPClonedWithinModule)
for (DISubprogram *ISP : DIFinder.subprograms()) { MD.insert(ISP);
if (ISP != SPClonedWithinModule)
MD.insert(ISP);
}
// If a subprogram isn't going to be cloned skip its lexical blocks as well. // If a subprogram isn't going to be cloned skip its lexical blocks as well.
for (DIScope *S : DIFinder.scopes()) { for (DIScope *S : DIFinder.scopes()) {
auto *LScope = dyn_cast<DILocalScope>(S); auto *LScope = dyn_cast<DILocalScope>(S);
if (LScope && LScope->getSubprogram() != SPClonedWithinModule) if (LScope && LScope->getSubprogram() != SPClonedWithinModule)
MD.insert(S); MD.insert(S);
} }
for (DICompileUnit *CU : DIFinder.compile_units()) for (DICompileUnit *CU : DIFinder.compile_units())
MD.insert(CU); MD.insert(CU);
for (DIType *Type : DIFinder.types()) for (DIType *Type : DIFinder.types())
MD.insert(Type); MD.insert(Type);
} else {
assert(!SPClonedWithinModule &&
"Subprogram should be in DIFinder->subprogram_count()...");
}
return MD; return MD;
} }