shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[LV] Don't calculate scalar costs for scalable VFs in setVectorizedCallDecision (#152713)

Browse Source 
In setVectorizedCallDecision we attempt to calculate the scalar costs
for vectorisation calls, even for scalable VFs where we already know the
answer is Invalid. We can avoid doing unnecessary work by skipping this
completely for scalable vectors.
This commit is contained in:
David Sherwood 2025-08-20 15:00:31 +01:00 committed by GitHub
parent 694a488708
commit e172110d12
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 14 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
llvm/lib/Transforms/Vectorize/LoopVectorize.cpp
View File

@ -5832,14 +5832,22 @@ void LoopVectorizationCostModel::setVectorizedCallDecision(ElementCount VF) {
// assumed to be vectors, so we need to extract individual elements from // assumed to be vectors, so we need to extract individual elements from
// there, execute VF scalar calls, and then gather the result into the // there, execute VF scalar calls, and then gather the result into the
// vector return value. // vector return value.
InstructionCost ScalarCallCost = if (VF.isFixed()) {
TTI.getCallInstrCost(ScalarFunc, ScalarRetTy, ScalarTys, CostKind); InstructionCost ScalarCallCost =
TTI.getCallInstrCost(ScalarFunc, ScalarRetTy, ScalarTys, CostKind);
// Compute costs of unpacking argument values for the scalar calls and // Compute costs of unpacking argument values for the scalar calls and
// packing the return values to a vector. // packing the return values to a vector.
InstructionCost ScalarizationCost = getScalarizationOverhead(CI, VF); InstructionCost ScalarizationCost = getScalarizationOverhead(CI, VF);
ScalarCost = ScalarCallCost * VF.getKnownMinValue() + ScalarizationCost;
} else {
// There is no point attempting to calculate the scalar cost for a
// scalable VF as we know it will be Invalid.
assert(!getScalarizationOverhead(CI, VF).isValid() &&
"Unexpected valid cost for scalarizing scalable vectors");
ScalarCost = InstructionCost::getInvalid();
}
ScalarCost = ScalarCallCost * VF.getKnownMinValue() + ScalarizationCost;
// Honor ForcedScalars and UniformAfterVectorization decisions. // Honor ForcedScalars and UniformAfterVectorization decisions.
// TODO: For calls, it might still be more profitable to widen. Use // TODO: For calls, it might still be more profitable to widen. Use
// VPlan-based cost model to compare different options. // VPlan-based cost model to compare different options.