shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions 6 Packages Projects Releases Wiki Activity

[BOLT][NFC] Stop populating unnecessary samples into MemSamples (#179472)

Browse Source 
Currently, many unnecessary samples are populated into MemSamples,
including zero-initialized samples and samples in which the PC address
is not contained in any BinaryFunction. But these samples are totally
skipped during processing and the whole MemSamples vector is cleared
immediately after processing. So, we could just stop populating these
samples into MemSamples, which would reduce maximum resident set size
when processing a large perf.data.
This commit is contained in:
Shanzhi Chen 2026-02-09 11:27:55 +08:00 committed by GitHub
parent 0f264368e8
commit e4674b85e9
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
bolt/lib/Profile/DataAggregator.cpp
View File

@ -1729,10 +1729,10 @@ std::error_code DataAggregator::parseMemEvents() {
if (std::error_code EC = Sample.getError())
return EC;
if (BinaryFunction *BF = getBinaryFunctionContainingAddress(Sample->PC))
if (BinaryFunction *BF = getBinaryFunctionContainingAddress(Sample->PC)) {
BF->setHasProfileAvailable();
MemSamples.emplace_back(std::move(Sample.get()));
MemSamples.emplace_back(std::move(Sample.get()));
}
}
return std::error_code();