From ef5e5ef6dd554e4fdc5c5c86e0969aa0455d2d8d Mon Sep 17 00:00:00 2001 From: Maksim Levental Date: Wed, 24 Sep 2025 12:24:40 -0400 Subject: [PATCH] [MLIR][Bazel] correctly fix bazel build after 59e74a0 (#160539) https://github.com/llvm/llvm-project/pull/160508 wasn't the correct fix - the fix just disabled the test because https://github.com/llvm/llvm-project/blob/59e74a0749203998b3e5fd9bc6525de148db28ab/mlir/test/Examples/standalone/lit.local.cfg#L18 is now always `False` (`if not "0"` is always `False`). This PR is the correct fix. --- mlir/test/lit.site.cfg.py.in | 2 +- utils/bazel/llvm-project-overlay/mlir/BUILD.bazel | 4 ++-- utils/bazel/llvm-project-overlay/mlir/test/BUILD.bazel | 1 + 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/mlir/test/lit.site.cfg.py.in b/mlir/test/lit.site.cfg.py.in index c7a0bbe114fe..1aaf7989e3ce 100644 --- a/mlir/test/lit.site.cfg.py.in +++ b/mlir/test/lit.site.cfg.py.in @@ -60,7 +60,7 @@ config.mlir_run_cuda_sm80_tests = @MLIR_RUN_CUDA_SM80_TESTS@ config.mlir_run_cuda_sm80_lt_tests = @MLIR_RUN_CUDA_SM80_LT_TESTS@ config.mlir_run_cuda_sm90_tests = @MLIR_RUN_CUDA_SM90_TESTS@ config.mlir_include_integration_tests = @MLIR_INCLUDE_INTEGRATION_TESTS@ -config.llvm_shared_libs_build = "@BUILD_SHARED_LIBS@" +config.llvm_shared_libs_build = @BUILD_SHARED_LIBS@ config.arm_emulator_executable = "@ARM_EMULATOR_EXECUTABLE@" # Some tests marked with 'UNSUPPORTED: target=aarch64{{.*}}' are still run when # configured with ARM_EMULATOR_EXECUTABLE and the default target is not aarch64. diff --git a/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel b/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel index 5ce8822aab87..2a0cc30b2267 100644 --- a/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel +++ b/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel @@ -7713,8 +7713,8 @@ cc_library( "lib/Transforms/*.cpp", ]), hdrs = [ - "include/mlir/Transforms/CSE.h", "include/mlir/Transforms/BubbleDownMemorySpaceCasts.h", + "include/mlir/Transforms/CSE.h", "include/mlir/Transforms/EndomorphismSimplification.h", "include/mlir/Transforms/HomomorphismSimplification.h", "include/mlir/Transforms/LocationSnapshot.h", @@ -12704,8 +12704,8 @@ cc_library( deps = [ ":DialectUtils", ":IR", - ":Support", ":MemOpInterfacesIncGen", + ":Support", ], ) diff --git a/utils/bazel/llvm-project-overlay/mlir/test/BUILD.bazel b/utils/bazel/llvm-project-overlay/mlir/test/BUILD.bazel index 469fcee8d974..7e36d0ba787b 100644 --- a/utils/bazel/llvm-project-overlay/mlir/test/BUILD.bazel +++ b/utils/bazel/llvm-project-overlay/mlir/test/BUILD.bazel @@ -31,6 +31,7 @@ expand_template( "@LIT_SITE_CFG_IN_HEADER@": LIT_SITE_CFG_IN_HEADER, "@LLVM_TOOLS_DIR@": package_path("//llvm:BUILD"), "@ENABLE_SHARED@": "1", + "@BUILD_SHARED_LIBS@": "1", "@ENABLE_ASSERTIONS@": "1", "@MLIR_SOURCE_DIR@": package_path("//mlir:BUILD"), "@MLIR_TOOLS_DIR@": package_path("//mlir:BUILD"),