shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ARM: Remove unneeded ARM::fixup_arm_thumb_bl special case

Browse Source 
This is a weird special case added in 2015, simplifying an even older
condition. It is a no-op for ELF (isExternal is always false) and seems
unneeded for non-ELF.
This commit is contained in:
Fangrui Song 2025-08-22 01:08:33 -07:00
parent 2a59400003
commit f1aee598e7
1 changed files with 0 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
llvm/lib/Target/ARM/MCTargetDesc/ARMAsmBackend.cpp
View File

@ -937,17 +937,6 @@ bool ARMAsmBackend::shouldForceRelocation(const MCFixup &Fixup,
const MCValue &Target) { const MCValue &Target) {
const MCSymbol *Sym = Target.getAddSym(); const MCSymbol *Sym = Target.getAddSym();
const unsigned FixupKind = Fixup.getKind(); const unsigned FixupKind = Fixup.getKind();
if (FixupKind == ARM::fixup_arm_thumb_bl) {
assert(Sym && "How did we resolve this?");
// If the symbol is external the linker will handle it.
// FIXME: Should we handle it as an optimization?
// If the symbol is out of range, produce a relocation and hope the
// linker can handle it. GNU AS produces an error in this case.
if (Sym->isExternal())
return true;
}
// Create relocations for unconditional branches to function symbols with // Create relocations for unconditional branches to function symbols with
// different execution mode in ELF binaries. // different execution mode in ELF binaries.
if (needsInterworking(*Asm, Sym, Fixup.getKind())) if (needsInterworking(*Asm, Sym, Fixup.getKind()))