shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions 6 Packages Projects Releases Wiki Activity

[lldb-dap][NFC] Add missed references (#174455)

Browse Source 
Pass `args` as const reference to methods.
This commit is contained in:
Sergei Druzhkov 2026-01-05 21:30:54 +03:00 committed by GitHub
parent 7a174c91f3
commit f31e8e930b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lldb/tools/lldb-dap/ClientLauncher.cpp
View File

@ -45,7 +45,7 @@ std::string VSCodeLauncher::URLEncode(llvm::StringRef str) {
}
std::string
VSCodeLauncher::GetLaunchURL(const std::vector<llvm::StringRef> args) const {
VSCodeLauncher::GetLaunchURL(const std::vector<llvm::StringRef> &args) const {
assert(!args.empty() && "empty launch args");
std::vector<std::string> encoded_launch_args;
@ -59,7 +59,7 @@ VSCodeLauncher::GetLaunchURL(const std::vector<llvm::StringRef> args) const {
.str();
}
llvm::Error VSCodeLauncher::Launch(const std::vector<llvm::StringRef> args) {
llvm::Error VSCodeLauncher::Launch(const std::vector<llvm::StringRef> &args) {
const std::string launch_url = GetLaunchURL(args);
const std::string command =
llvm::formatv("code --open-url {0}", launch_url).str();
@ -68,7 +68,7 @@ llvm::Error VSCodeLauncher::Launch(const std::vector<llvm::StringRef> args) {
return llvm::Error::success();
}
llvm::Error VSCodeURLPrinter::Launch(const std::vector<llvm::StringRef> args) {
llvm::Error VSCodeURLPrinter::Launch(const std::vector<llvm::StringRef> &args) {
llvm::outs() << GetLaunchURL(args) << '\n';
return llvm::Error::success();
}

8
lldb/tools/lldb-dap/ClientLauncher.h
View File

@ -23,7 +23,7 @@ public:
};
virtual ~ClientLauncher() = default;
virtual llvm::Error Launch(const std::vector<llvm::StringRef> args) = 0;
virtual llvm::Error Launch(const std::vector<llvm::StringRef> &args) = 0;
static std::optional<Client> GetClientFrom(llvm::StringRef str);
static std::unique_ptr<ClientLauncher> GetLauncher(Client client);
@ -33,16 +33,16 @@ class VSCodeLauncher : public ClientLauncher {
public:
using ClientLauncher::ClientLauncher;
llvm::Error Launch(const std::vector<llvm::StringRef> args) override;
llvm::Error Launch(const std::vector<llvm::StringRef> &args) override;
std::string GetLaunchURL(const std::vector<llvm::StringRef> args) const;
std::string GetLaunchURL(const std::vector<llvm::StringRef> &args) const;
static std::string URLEncode(llvm::StringRef str);
};
class VSCodeURLPrinter : public VSCodeLauncher {
using VSCodeLauncher::VSCodeLauncher;
llvm::Error Launch(const std::vector<llvm::StringRef> args) override;
llvm::Error Launch(const std::vector<llvm::StringRef> &args) override;
};
} // namespace lldb_dap