shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions 6 Packages Projects Releases Wiki Activity

[flang] Symbol for ENTRY with RESULT has Subroutine flag set (#177671)

Browse Source 
When creating a HostAssocDetails symbol for an ENTRY statement with an
explicit RESULT, name resolution unconditionally sets the Subroutine
flag on the symbol. Don't do that.

Fixes https://github.com/llvm/llvm-project/issues/177502.
This commit is contained in:
Peter Klausler 2026-01-27 08:22:44 -08:00 committed by GitHub
parent d3ebc63fb8
commit fbdb9d32cc
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 29 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
flang/lib/Semantics/resolve-names.cpp
View File

@ -5129,7 +5129,7 @@ void SubprogramVisitor::CreateEntry(
if (subpFlag == Symbol::Flag::Subroutine || distinctResultName) {
Symbol &assoc{MakeSymbol(entryName.source)};
assoc.set_details(HostAssocDetails{*entrySymbol});
assoc.set(Symbol::Flag::Subroutine);
assoc.set(subpFlag);
}
Resolve(entryName, *entrySymbol);
std::set<SourceName> dummies;

28
flang/test/Semantics/bug177502.f90 Normal file
View File

@ -0,0 +1,28 @@
!RUN: %python %S/test_symbols.py %s %flang_fc1
!DEF: /m Module
module m
!DEF: /m/k PUBLIC ObjectEntity INTEGER(4)
integer k
contains
!DEF: /m/f PUBLIC, RECURSIVE (Function) Subprogram REAL(4)
!DEF: /m/f/r ObjectEntity REAL(4)
recursive function f() result(r)
!REF: /m/f/r
real r
!DEF: /m/e PUBLIC (Function) Subprogram REAL(4)
!REF: /m/f/r
entry e() result(r)
!DEF: /m/f/e (Function) HostAssoc REAL(4)
!DEF: /m/f/ptr EXTERNAL, POINTER (Function) ProcEntity REAL(4)
procedure(e), pointer :: ptr => e
!REF: /m/k
k = k+1
!REF: /m/f/r
r = 20.0
!REF: /m/k
if (k==1) then
!REF: /m/f/ptr
if (ptr()/=20) error stop
end if
end function f
end module