shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions 6 Packages Projects Releases Wiki Activity

[ELF] Remove redundant sec->repl != sec check in BPSectionOrderer. NFC (#189214)

Browse Source 
ICF's InputSection::replace() calls markDead() on folded sections, so
`!sec->isLive()` already filters them.
This commit is contained in:
Fangrui Song 2026-03-29 00:38:03 -07:00 committed by GitHub
parent 71263dc615
commit fcd0e2cca0
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lld/ELF/BPSectionOrderer.cpp
View File

@ -77,11 +77,10 @@ DenseMap<const InputSectionBase *, int> elf::runBalancedPartitioning(
return;
auto *sec = dyn_cast_or_null<InputSection>(d->section);
// Skip section symbols. Skip empty, discarded, ICF folded sections, .bss.
// Skipping ICF folded sections reduces duplicate detection work in
// BPSectionOrderer.
// ICF folded sections are already dead (!isLive()), so no separate check
// is needed.
if (sym.isSection() || !sec || sec->size == 0 || !sec->isLive() ||
sec->repl != sec || !sec->content().data() ||
!orderer.secToSym.try_emplace(sec, d).second)
!sec->content().data() || !orderer.secToSym.try_emplace(sec, d).second)
return;
rootSymbolToSectionIdxs[CachedHashStringRef(
lld::utils::getRootSymbol(sym.getName()))]