llvm-project

shylie/llvm-project

Fork 0

Commit Graph

Author	SHA1	Message	Date
Jan Voung	27e78e68a6	[clang][dataflow] Remove a deprecated CachedConstAccessorsLattice API (#127001 ) We've already migrated known users from the old to the new version of getOrCreateConstMethodReturnStorageLocation. The conversion is pretty straightforward as well, if there are out-of-tree users: Previously: use CallExpr as argument New: get the direct Callee from CallExpr, null check, and use that as the argument instead.	2025-02-13 08:57:54 -05:00
Jan Voung	72a28a3bf0	[clang][dataflow] Use smart pointer caching in unchecked optional accessor (#120249 ) Part 2 (and final part) following https://github.com/llvm/llvm-project/pull/120102 Allows users to do things like: ``` if (o->x.has_value()) { ((o).x).value(); } ``` where the `->` and `` are operator overload calls. A user could instead extract the nested optional into a local variable once instead of doing two accessor calls back to back, but currently they are unsure why the code is flagged.	2025-01-08 08:27:16 -05:00
Jan Voung	87dd5dc8f0	[clang][dataflow] Add a lattice to help cache const accessor methods (#111006 ) By caching const accessor methods we can sometimes treat method call results as stable (e.g., for issue https://github.com/llvm/llvm-project/issues/58510). Users can clear the cache when a non-const method is called that may modify the state of an object. This is represented as mixin. It will be used in a follow on patch to change bugprone-unchecked-optional-access's lattice from NoopLattice to CachedConstAccessorsLattice<NoopLattice>, along with some additional transfer functions.	2024-10-16 12:10:39 -04:00

Author

SHA1

Message

Date

Jan Voung

27e78e68a6

[clang][dataflow] Remove a deprecated CachedConstAccessorsLattice API (#127001 )

We've already migrated known users from the old to the new version of
getOrCreateConstMethodReturnStorageLocation. The conversion is pretty
straightforward as well, if there are out-of-tree users:

Previously: use CallExpr as argument
New: get the direct Callee from CallExpr, null check, and use that as
the argument instead.

2025-02-13 08:57:54 -05:00

Jan Voung

72a28a3bf0

[clang][dataflow] Use smart pointer caching in unchecked optional accessor (#120249 )

Part 2 (and final part) following
https://github.com/llvm/llvm-project/pull/120102
Allows users to do things like:

```
if (o->x.has_value()) {
  ((*o).x).value();
}
```
where the `->` and `*` are operator overload calls.

A user could instead extract the nested optional into a local variable
once instead of doing two accessor calls back to back, but currently
they are unsure why the code is flagged.

2025-01-08 08:27:16 -05:00

Jan Voung

87dd5dc8f0

[clang][dataflow] Add a lattice to help cache const accessor methods (#111006 )

By caching const accessor methods we can sometimes treat method call
results as stable (e.g., for issue
https://github.com/llvm/llvm-project/issues/58510). Users can clear the
cache when a non-const method is called that may modify the state of an
object.
This is represented as mixin.

It will be used in a follow on patch to change
bugprone-unchecked-optional-access's lattice from NoopLattice to
CachedConstAccessorsLattice<NoopLattice>, along with some additional
transfer functions.

2024-10-16 12:10:39 -04:00

3 Commits